Document diagnostics supersede workspace diagnostics #49408
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dibarbet
approved these changes
Nov 16, 2020
allisonchou
approved these changes
Nov 16, 2020
src/Features/LanguageServer/Protocol/Handler/Diagnostics/WorkspacePullDiagnosticHandler.cs
Outdated
Show resolved
Hide resolved
…pacePullDiagnosticHandler.cs Co-authored-by: Allison Chou <allichou@microsoft.com>
davidwengier
approved these changes
Nov 16, 2020
| @@ -35,14 +34,26 @@ internal class DocumentPullDiagnosticHandler : AbstractPullDiagnosticHandler<Doc | |||
| => diagnosticsParams.TextDocument; | |||
|
|
|||
| protected override DiagnosticReport CreateReport(TextDocumentIdentifier? identifier, VSDiagnostic[]? diagnostics, string? resultId) | |||
| => new DiagnosticReport { Diagnostics = diagnostics, ResultId = resultId }; | |||
| => new DiagnosticReport | |||
There was a problem hiding this comment.
Should we set an Identifier here just in case? I worry that the workspace report technically has Supersedes = 0, and this has an identifier of 0, and whilst I'm sure the platform handles that, it still makes me nervous.
There was a problem hiding this comment.
sure. i dont' mind being explicit.
|
Hello @CyrusNajmabadi! Because this pull request has the p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (
|
ghost
merged commit 
ghost
added this to the 
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.