From bc11a02e107ebb5cbb3e38ca59ed132655809a96 Mon Sep 17 00:00:00 2001 From: tmat Date: Mon, 18 Jul 2022 13:14:22 -0700 Subject: [PATCH] All text editor options are roaming --- .../Core/Options/NavigationBarViewOptionsStorage.cs | 2 +- .../Core/Options/SignatureHelpViewOptionsStorage.cs | 2 +- .../Protocol/Features/Options/CompletionOptionsStorage.cs | 4 ++-- .../Compiler/Core/Formatting/FormattingOptions2.cs | 6 +++--- 4 files changed, 7 insertions(+), 7 deletions(-) diff --git a/src/EditorFeatures/Core/Options/NavigationBarViewOptionsStorage.cs b/src/EditorFeatures/Core/Options/NavigationBarViewOptionsStorage.cs index 1d7ec8496b7ff..24d9f3fc65c87 100644 --- a/src/EditorFeatures/Core/Options/NavigationBarViewOptionsStorage.cs +++ b/src/EditorFeatures/Core/Options/NavigationBarViewOptionsStorage.cs @@ -11,5 +11,5 @@ internal sealed class NavigationBarViewOptionsStorage private const string FeatureName = "NavigationBarOptions"; public static readonly PerLanguageOption2 ShowNavigationBar = new( - FeatureName, "ShowNavigationBar", defaultValue: true, new LocalClientSettingsStorageLocation("TextEditor.%LANGUAGE%.Dropdown Bar")); + FeatureName, "ShowNavigationBar", defaultValue: true, new RoamingProfileStorageLocation("TextEditor.%LANGUAGE%.Dropdown Bar")); } diff --git a/src/EditorFeatures/Core/Options/SignatureHelpViewOptionsStorage.cs b/src/EditorFeatures/Core/Options/SignatureHelpViewOptionsStorage.cs index 3d02f2959d98e..b887e3fbdbaf3 100644 --- a/src/EditorFeatures/Core/Options/SignatureHelpViewOptionsStorage.cs +++ b/src/EditorFeatures/Core/Options/SignatureHelpViewOptionsStorage.cs @@ -11,5 +11,5 @@ internal sealed class SignatureHelpViewOptionsStorage private const string FeatureName = "SignatureHelpOptions"; public static readonly PerLanguageOption2 ShowSignatureHelp = new( - FeatureName, "ShowSignatureHelp", defaultValue: true, new LocalClientSettingsStorageLocation("TextEditor.%LANGUAGE%.Auto List Params")); + FeatureName, "ShowSignatureHelp", defaultValue: true, new RoamingProfileStorageLocation("TextEditor.%LANGUAGE%.Auto List Params")); } diff --git a/src/Features/LanguageServer/Protocol/Features/Options/CompletionOptionsStorage.cs b/src/Features/LanguageServer/Protocol/Features/Options/CompletionOptionsStorage.cs index 725dda47f9acd..e12ebce56e77b 100644 --- a/src/Features/LanguageServer/Protocol/Features/Options/CompletionOptionsStorage.cs +++ b/src/Features/LanguageServer/Protocol/Features/Options/CompletionOptionsStorage.cs @@ -49,11 +49,11 @@ public static CompletionOptions GetCompletionOptions(this IGlobalOptionService o public static readonly PerLanguageOption2 HideAdvancedMembers = new( "CompletionOptions", "HideAdvancedMembers", CompletionOptions.Default.HideAdvancedMembers, - new LocalClientSettingsStorageLocation("TextEditor.%LANGUAGE%.Hide Advanced Auto List Members")); + new RoamingProfileStorageLocation("TextEditor.%LANGUAGE%.Hide Advanced Auto List Members")); public static readonly PerLanguageOption2 TriggerOnTyping = new( "CompletionOptions", "TriggerOnTyping", CompletionOptions.Default.TriggerOnTyping, - new LocalClientSettingsStorageLocation("TextEditor.%LANGUAGE%.Auto List Members")); + new RoamingProfileStorageLocation("TextEditor.%LANGUAGE%.Auto List Members")); public static readonly PerLanguageOption2 TriggerOnTypingLetters = new(nameof(CompletionOptions), nameof(TriggerOnTypingLetters), CompletionOptions.Default.TriggerOnTypingLetters, storageLocation: new RoamingProfileStorageLocation("TextEditor.%LANGUAGE%.Specific.TriggerOnTypingLetters")); diff --git a/src/Workspaces/SharedUtilitiesAndExtensions/Compiler/Core/Formatting/FormattingOptions2.cs b/src/Workspaces/SharedUtilitiesAndExtensions/Compiler/Core/Formatting/FormattingOptions2.cs index 8de387a714922..029a4ee3c9aef 100644 --- a/src/Workspaces/SharedUtilitiesAndExtensions/Compiler/Core/Formatting/FormattingOptions2.cs +++ b/src/Workspaces/SharedUtilitiesAndExtensions/Compiler/Core/Formatting/FormattingOptions2.cs @@ -41,19 +41,19 @@ public Provider() new(FeatureName, FormattingOptionGroups.IndentationAndSpacing, nameof(UseTabs), LineFormattingOptions.Default.UseTabs, storageLocations: ImmutableArray.Create( new EditorConfigStorageLocation("indent_style", s => s == "tab", isSet => isSet ? "tab" : "space"), - new LocalClientSettingsStorageLocation("TextEditor.%LANGUAGE%.Insert Tabs"))); + new RoamingProfileStorageLocation("TextEditor.%LANGUAGE%.Insert Tabs"))); public static PerLanguageOption2 TabSize = new(FeatureName, FormattingOptionGroups.IndentationAndSpacing, nameof(TabSize), LineFormattingOptions.Default.TabSize, storageLocations: ImmutableArray.Create( EditorConfigStorageLocation.ForInt32Option("tab_width"), - new LocalClientSettingsStorageLocation("TextEditor.%LANGUAGE%.Tab Size"))); + new RoamingProfileStorageLocation("TextEditor.%LANGUAGE%.Tab Size"))); public static PerLanguageOption2 IndentationSize = new(FeatureName, FormattingOptionGroups.IndentationAndSpacing, nameof(IndentationSize), LineFormattingOptions.Default.IndentationSize, storageLocations: ImmutableArray.Create( EditorConfigStorageLocation.ForInt32Option("indent_size"), - new LocalClientSettingsStorageLocation("TextEditor.%LANGUAGE%.Indent Size"))); + new RoamingProfileStorageLocation("TextEditor.%LANGUAGE%.Indent Size"))); public static PerLanguageOption2 NewLine = new(FeatureName, FormattingOptionGroups.NewLine, nameof(NewLine), LineFormattingOptions.Default.NewLine,