Do not report a secondary NFW exception after already reporting one earlier. #64412
+10
−23
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
genlu
reviewed
Oct 3, 2022
...orkspaces/Core/Portable/Workspace/Host/SyntaxTreeFactory/AbstractSyntaxTreeFactoryService.cs
Outdated
Show resolved
Hide resolved
CyrusNajmabadi
commented
Oct 3, 2022
...orkspaces/Core/Portable/Workspace/Host/SyntaxTreeFactory/AbstractSyntaxTreeFactoryService.cs
Outdated
Show resolved
Hide resolved
…AbstractSyntaxTreeFactoryService.cs
genlu
reviewed
Oct 3, 2022
|
|
||
| // If this is hit the cancellation token passed to the service implementation did not use the correct token, | ||
| // and the resulting exception was not a ConnectionLostException. | ||
| return ExceptionUtilities.Unreachable(); |
There was a problem hiding this comment.
Is this the cause of the second NFW?
genlu
approved these changes
Oct 3, 2022
|
@jasonmalinowski going to still wait on you for this to make sure i'm ok on this. |
arkalyanms
approved these changes
Oct 3, 2022
jasonmalinowski
approved these changes
Oct 5, 2022
ghost
added this to the 
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.