Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

Port PR #7212 to stabilization #7231

Merged
merged 3 commits into from Dec 4, 2015

Conversation

Projects
None yet
2 participants
Member

DustinCampbell commented Dec 4, 2015

This is the same as PR #7212 except that unit tests are updated to be synchronous since the unit test infrastructure has diverged in master. The same tests are there. They just aren't async.

Tagging @dotnet/roslyn-ide

DustinCampbell added some commits Dec 3, 2015

Ensure that an EnvDTE.CodeParameter.Name returns the correct value fo…
…r parameters defined in metadata

The issue is that the symbol display system will not return a name for a parameter unless
SymbolDisplayParameterOptions.IncludeName is set. This behavior seems like it might ultimately be
a bug in symbol display as that option is intended to control the display the parameters owned
by the targeted symbol, but probably shouldn't affect the display of the targeted symbol. However,
rather than updating symbol display (which would potentially have larger downstream impact), we'll
just include the option in this case.

@DustinCampbell DustinCampbell self-assigned this Dec 4, 2015

DustinCampbell added a commit that referenced this pull request Dec 4, 2015

@DustinCampbell DustinCampbell merged commit 55c7c36 into dotnet:stabilization Dec 4, 2015

5 checks passed

prtest/lin/dbg/unit32 Build finished. 15009 tests run, 568 skipped, 0 failed.
Details
prtest/mac/dbg/unit32 Build finished. 15009 tests run, 567 skipped, 0 failed.
Details
prtest/win/dbg/eta Build finished. No test results found.
Details
prtest/win/dbg/unit32 Build finished. 60840 tests run, 320 skipped, 0 failed.
Details
prtest/win/dbg/unit64 Build finished. 60690 tests run, 2548 skipped, 0 failed.
Details

@DustinCampbell DustinCampbell deleted the DustinCampbell:issue-7210-stabilization branch Dec 14, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment