Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

Port PR #7217 to stabilization #7234

Merged
merged 1 commit into from Dec 4, 2015

Conversation

Projects
None yet
3 participants
Member

DustinCampbell commented Dec 4, 2015

This is the same as PR #7217 except that unit tests are updated to be synchronous since the unit test infrastructure has diverged in master. The same tests are there. They just aren't async.

Tagging @dotnet/roslyn-ide

Explicitly remove code model elements from the CleanableWeakComHandle…
…Table when they are deleted

There are WinForms scenarios where code model elements can be deleted and re-added, for example,
when the modifiers of a control on the designer surface are changed the control will be deleted
and immediately re-added. We must be sure to delete the element's node key from the
CleanableWeakComHandleTable or else an exception will be thrown when the element is re-added with
the same node key.

@DustinCampbell DustinCampbell self-assigned this Dec 4, 2015

Member

DustinCampbell commented Dec 4, 2015

retest prtest/win/dbg/unit32 please

Member

DustinCampbell commented Dec 4, 2015

retest prtest/mac/dbg/unit32 please

Member

DustinCampbell commented Dec 4, 2015

retest prtest/win/dbg/unit32 please

DustinCampbell added a commit that referenced this pull request Dec 4, 2015

@DustinCampbell DustinCampbell merged commit da92217 into dotnet:stabilization Dec 4, 2015

5 checks passed

prtest/lin/dbg/unit32 Build finished. 15009 tests run, 568 skipped, 0 failed.
Details
prtest/mac/dbg/unit32 Build finished. 15009 tests run, 567 skipped, 0 failed.
Details
prtest/win/dbg/eta Build finished. No test results found.
Details
prtest/win/dbg/unit32 Build finished. 60818 tests run, 320 skipped, 0 failed.
Details
prtest/win/dbg/unit64 Build finished. 60668 tests run, 2526 skipped, 0 failed.
Details

@DustinCampbell DustinCampbell deleted the DustinCampbell:issue-7216-stabilization branch Dec 14, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment