From 7740dbd7fdb54e87c6aec5eb7b193bc7d21b68f1 Mon Sep 17 00:00:00 2001 From: Bruce Forstall Date: Sat, 16 Mar 2024 13:21:00 -0700 Subject: [PATCH] Fix SuperPMI collections (#99867) The `produce_repro` argument needs to be initialized for collections. --- src/coreclr/scripts/superpmi.py | 13 +++++++++---- 1 file changed, 9 insertions(+), 4 deletions(-) diff --git a/src/coreclr/scripts/superpmi.py b/src/coreclr/scripts/superpmi.py index cff7695bed0de..91c47777641ac 100644 --- a/src/coreclr/scripts/superpmi.py +++ b/src/coreclr/scripts/superpmi.py @@ -620,7 +620,7 @@ def run_to_completion(self, async_callback, *extra_args): loop = asyncio.new_event_loop() asyncio.set_event_loop(loop) - + loop.run_until_complete(self.__run_to_completion__(async_callback, *extra_args)) os.environ.clear() os.environ.update(reset_env) @@ -1867,11 +1867,11 @@ def write_jit_options(coreclr_args, write_fh): Args: coreclr_args: args class instance write_fh: file to output to - + """ base_options = [] diff_options = [] - + if coreclr_args.jitoption: base_options += coreclr_args.jitoption diff_options += coreclr_args.jitoption @@ -4500,7 +4500,7 @@ def verify_replay_common_args(): "produce_repro", lambda unused: True, "Unable to set produce_repro") - + coreclr_args.verify(args, "private_store", lambda item: True, @@ -4592,6 +4592,11 @@ def verify_base_diff_args(): lambda unused: True, "Method context not valid") + coreclr_args.verify(args, + "produce_repro", # The replay code checks this, so make sure it's set + lambda unused: True, + "Unable to set produce_repro") + coreclr_args.verify(args, "collection_command", lambda unused: True,