Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider parallelizing the crossgen phase of the installer build #1365

Open
tannergooding opened this issue Jan 7, 2020 · 3 comments
Open

Consider parallelizing the crossgen phase of the installer build #1365

tannergooding opened this issue Jan 7, 2020 · 3 comments

Comments

@tannergooding
Copy link
Member

@tannergooding tannergooding commented Jan 7, 2020

It currently looks like the crossgen phase of the installer build is done in serial rather than parallel. It would likely be worthwhile to change this up to be parallelized instead to take full advantage of the underlying hardware.

This is currently done via MSBuild batching: https://github.com/dotnet/arcade/blob/cc0bbc15d0b038b4949bc0c45f3436973ec11106/src/Microsoft.DotNet.Build.Tasks.SharedFramework.Sdk/targets/framework.dependency.targets#L408

This would likely need to be changed to be a parallel <MSBuild Projects="$(MSBuildThisProjectFullPath)" ... but may require various props/etc to be transferred over.

@tannergooding

This comment has been minimized.

Copy link
Member Author

@tannergooding tannergooding commented Jan 7, 2020

CC. @dagood

@dagood

This comment has been minimized.

Copy link
Member

@dagood dagood commented Jan 9, 2020

We should also add -nologo to the calls so we don't end up with interleaved output, and to reduce log spam.

Edit: This bit already done by dotnet/arcade#4567. 🙂

@danmosemsft

This comment has been minimized.

Copy link
Member

@danmosemsft danmosemsft commented Jan 23, 2020

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants
You can’t perform that action at this time.