Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provide a set of unit tests over the new single-precision math APIs #6837

Closed
tannergooding opened this issue Oct 18, 2016 · 2 comments
Closed

Provide a set of unit tests over the new single-precision math APIs #6837

tannergooding opened this issue Oct 18, 2016 · 2 comments

Comments

@tannergooding
Copy link
Member

@tannergooding tannergooding commented Oct 18, 2016

PR dotnet/coreclr#5492 implemented dotnet/corefx#1151, by providing scalar single-precision floating-point support for many of the trigonometric, logarithmic, and other common mathematical functions.

However, there is still the additional work that needs to be done to provide a full set of unit tests over the new single-precision math APIs.

This work is partially blocked on dotnet/corefx#12183 being merged so that a proper NuGet package is available with the appropriate contract assembly.

@tannergooding
Copy link
Member Author

@tannergooding tannergooding commented Oct 18, 2016

I am self-assigning these for the time being and am going to work on getting these completed.

Loading

@tannergooding tannergooding self-assigned this Oct 18, 2016
@tannergooding
Copy link
Member Author

@tannergooding tannergooding commented Feb 24, 2017

This was resolved with dotnet/coreclr#9717 where I ported the CoreMangLib/cti/system/math tests over to cover the new single-precision math APIs (CoreMangLib/cti/system/mathf)

Loading

@msftgits msftgits transferred this issue from dotnet/coreclr Jan 31, 2020
@tannergooding tannergooding removed their assignment May 26, 2020
@msftbot msftbot bot locked as resolved and limited conversation to collaborators Dec 28, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
1 participant