-
Notifications
You must be signed in to change notification settings - Fork 5k
[8.0-preview.5] Possible Issue with AsyncLocal<T>/TaskCreationOptions.RunContinuationsAsynchronously #87628
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
Tagging subscribers to this area: @dotnet/area-system-threading-tasks Issue DetailsDescriptionI have a number of applications that were targeting .NET 8 preview 4 that have been upgraded to .NET preview 5 this week. In four different applications (only 3 are public), I've observed issues with their UI tests that use Microsoft.Playwright where a
These failures occur on Windows, macOS and Linux, but exactly what fails seems to vary slightly between the different applications and operating systems. After doing various investigation, including debugging one of the applications consuming Microsoft.Playwright from source, I wonder if there's an issue somewhere related to The code for the relevant parts of Playwright in v1.35.0 using these are here:
When referencing the Playwright code from source I added the following lines before the if (ApiZone is null)
{
throw new InvalidOperationException("ApiZone is null.");
}
if (ApiZone.Value is null)
{
throw new InvalidOperationException("ApiZone.Value is null.");
}
if (ApiZone.Value[0] is null)
{
throw new InvalidOperationException("ApiZone.Value[0] is null.");
} Re-running the tests with this edit changes the test failures to the following:
This seems to suggest to me that the Observing the UI tests with headless mode disabled (as well as reviewing screenshots and recordings) don't seem to suggest any issues with the applications themselves in terms of their expected behaviour (i.e. genuine test failures), it seems that something is just causing Playwright to fail internally. An additional factor to me thinking this is something related to Reproduction Steps
Expected behaviorThe tests pass. Actual behaviorOne or more tests fail with an exception similar to the below:
Regression?Yes. The test pass with .NET 7.0.7 and with .NET 8 preview 4. Known WorkaroundsNone. Configuration
Other informationNo response
|
We enabled DynamicPGO by default in .NET 8 Preview 5, and it could be a contributing factor. Can you check if these failures persist even when PGO is disabled? You can disable via
in the
in the |
Disable Dynamic PGO to work around dotnet/runtime#87628.
Disable Dynamic PGO to work around dotnet/runtime#87628.
Disable Dynamic PGO to work around dotnet/runtime#87628.
* Update .NET SDK Update .NET SDK to version 8.0.100-preview.5.23303.2. --- updated-dependencies: - dependency-name: Microsoft.NET.Sdk dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: costellobot <102549341+costellobot@users.noreply.github.com> * Bump .NET NuGet packages Bumps .NET dependencies to their latest versions for the .NET 8.0.100-preview.5.23303.2 SDK. Bumps Microsoft.AspNetCore.Mvc.Testing from 8.0.0-preview.4.23260.4 to 8.0.0-preview.5.23302.2. Bumps Microsoft.EntityFrameworkCore.Sqlite from 8.0.0-preview.4.23259.3 to 8.0.0-preview.5.23280.1. --- updated-dependencies: - dependency-name: Microsoft.AspNetCore.Mvc.Testing dependency-type: direct:production update-type: version-update:semver-major - dependency-name: Microsoft.EntityFrameworkCore.Sqlite dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: costellobot <102549341+costellobot@users.noreply.github.com> * Suppress CA1861 Suppress CA1861 warnings in sample application. * Add null checks Ensure that elements aren't null. * Ensure tracks are visible Try ensuring the elements are visible before returning them to the test code. * Disable Dynamic PGO Disable Dynamic PGO to work around dotnet/runtime#87628. --------- Signed-off-by: costellobot <102549341+costellobot@users.noreply.github.com> Co-authored-by: Martin Costello <martin@martincostello.com>
* Update .NET SDK Update .NET SDK to version 8.0.100-preview.5.23303.2. --- updated-dependencies: - dependency-name: Microsoft.NET.Sdk dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: costellobot <102549341+costellobot@users.noreply.github.com> * Bump Microsoft.AspNetCore.Mvc.Testing from 8.0.0-preview.4.23260.4 to 8.0.0-preview.5.23302.2 Bumps Microsoft.AspNetCore.Mvc.Testing from 8.0.0-preview.4.23260.4 to 8.0.0-preview.5.23302.2. --- updated-dependencies: - dependency-name: Microsoft.AspNetCore.Mvc.Testing dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: costellobot <102549341+costellobot@users.noreply.github.com> * Suppress CA1861 Suppress CA1861 warnings in tests. * Use TimeProvider User `TimeProvider` to fix obsolete warning for `ISystemClock`. * Disable Dynamic PGO Disable Dynamic PGO to work around dotnet/runtime#87628. --------- Signed-off-by: costellobot <102549341+costellobot@users.noreply.github.com> Co-authored-by: martincostello <martin@martincostello.com>
* Update .NET SDK Update .NET SDK to version 8.0.100-preview.5.23303.2. --- updated-dependencies: - dependency-name: Microsoft.NET.Sdk dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: costellobot <102549341+costellobot@users.noreply.github.com> * Bump .NET NuGet packages Bumps .NET dependencies to their latest versions for the .NET 8.0.100-preview.5.23303.2 SDK. Bumps Microsoft.AspNetCore.Authentication.Facebook from 8.0.0-preview.4.23260.4 to 8.0.0-preview.5.23302.2. Bumps Microsoft.AspNetCore.Authentication.Google from 8.0.0-preview.4.23260.4 to 8.0.0-preview.5.23302.2. Bumps Microsoft.AspNetCore.Authentication.MicrosoftAccount from 8.0.0-preview.4.23260.4 to 8.0.0-preview.5.23302.2. Bumps Microsoft.AspNetCore.Authentication.Twitter from 8.0.0-preview.4.23260.4 to 8.0.0-preview.5.23302.2. Bumps Microsoft.AspNetCore.AzureAppServices.HostingStartup from 8.0.0-preview.4.23260.4 to 8.0.0-preview.5.23302.2. Bumps Microsoft.AspNetCore.Mvc.Testing from 8.0.0-preview.4.23260.4 to 8.0.0-preview.5.23302.2. Bumps Microsoft.Extensions.Http.Polly from 8.0.0-preview.4.23260.4 to 8.0.0-preview.5.23302.2. --- updated-dependencies: - dependency-name: Microsoft.AspNetCore.Authentication.Facebook dependency-type: direct:production update-type: version-update:semver-major - dependency-name: Microsoft.AspNetCore.Authentication.Google dependency-type: direct:production update-type: version-update:semver-major - dependency-name: Microsoft.AspNetCore.Authentication.MicrosoftAccount dependency-type: direct:production update-type: version-update:semver-major - dependency-name: Microsoft.AspNetCore.Authentication.Twitter dependency-type: direct:production update-type: version-update:semver-major - dependency-name: Microsoft.AspNetCore.AzureAppServices.HostingStartup dependency-type: direct:production update-type: version-update:semver-major - dependency-name: Microsoft.AspNetCore.Mvc.Testing dependency-type: direct:production update-type: version-update:semver-major - dependency-name: Microsoft.Extensions.Http.Polly dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: costellobot <102549341+costellobot@users.noreply.github.com> * Fix CA1861 warnings Fix (or suppress) new `CA1861` warnings. * Disable Dynamic PGO Disable Dynamic PGO to work around dotnet/runtime#87628. --------- Signed-off-by: costellobot <102549341+costellobot@users.noreply.github.com> Co-authored-by: martincostello <martin@martincostello.com>
I've updated all 4 applications to disable PGO and now all the tests pass as expected, so looks like Dynamic PGO was indeed the contributing factor. 🕵️ |
Ok, thanks for checking. Since you have a repro we can try it shouldn't be too hard to track this one down. |
Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch Issue DetailsDescriptionI have a number of applications that were targeting .NET 8 preview 4 that have been upgraded to .NET preview 5 this week. In four different applications (only 3 are public), I've observed issues with their UI tests that use Microsoft.Playwright where a
These failures occur on Windows, macOS and Linux, but exactly what fails seems to vary slightly between the different applications and operating systems. After doing various investigation, including debugging one of the applications consuming Microsoft.Playwright from source, I wonder if there's an issue somewhere related to The code for the relevant parts of Playwright in v1.35.0 using these are here:
When referencing the Playwright code from source I added the following lines before the if (ApiZone is null)
{
throw new InvalidOperationException("ApiZone is null.");
}
if (ApiZone.Value is null)
{
throw new InvalidOperationException("ApiZone.Value is null.");
}
if (ApiZone.Value[0] is null)
{
throw new InvalidOperationException("ApiZone.Value[0] is null.");
} Re-running the tests with this edit changes the test failures to the following:
This seems to suggest to me that the Observing the UI tests with headless mode disabled (as well as reviewing screenshots and recordings) don't seem to suggest any issues with the applications themselves in terms of their expected behaviour (i.e. genuine test failures), it seems that something is just causing Playwright to fail internally. An additional factor to me thinking this is something related to Reproduction Steps
Expected behaviorThe tests pass. Actual behaviorOne or more tests fail with an exception similar to the below:
Regression?Yes. The test pass with .NET 7.0.7 and with .NET 8 preview 4. Known WorkaroundsNone. Configuration
Other informationNo response
|
@dotnet/jit-contrib anyone want to dig in? If not, I will take a look when I have time. |
Is this an orphaned commit on a fork somewhere? I have ended up instead on the dotnet-vnext branch at martincostello/dependabot-helper@398cdd1 and then I undid the edit to Looks like I also need to install Powershell 7 and node.js? |
That commit was in a PR that squash merged into that branch once the tests passed. You'll need node/npm to build the JS for the UI and PowerShell 7 to use the build script, but if you don't want to use that you could run dotnet test manually with the equivalent command from it which would be something like this:
|
I found a 5th repo seemingly affected by this, but with a different failure mode, but ultimately an unexpected failure in the same area of the Playwright code:
Disabling Dynamic PGO also solved that issue. This might be easier for you to repro the issue with:
|
I wonder if the bug is that The actual (non-sanitized) stack is something like
and it seems possible that |
For example, we see
|
Opened a bug in playwright. Odd that this isn't auto-linking in some browser view, so will add the link here explicitly. |
* Update .NET SDK Update .NET SDK to version 8.0.100-preview.5.23303.2. --- updated-dependencies: - dependency-name: Microsoft.NET.Sdk dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: costellobot <102549341+costellobot@users.noreply.github.com> * Bump .NET NuGet packages Bumps .NET dependencies to their latest versions for the .NET 8.0.100-preview.5.23303.2 SDK. Bumps Microsoft.AspNetCore.Mvc.Testing from 8.0.0-preview.4.23260.4 to 8.0.0-preview.5.23302.2. Bumps Microsoft.EntityFrameworkCore.Sqlite from 8.0.0-preview.4.23259.3 to 8.0.0-preview.5.23280.1. --- updated-dependencies: - dependency-name: Microsoft.AspNetCore.Mvc.Testing dependency-type: direct:production update-type: version-update:semver-major - dependency-name: Microsoft.EntityFrameworkCore.Sqlite dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: costellobot <102549341+costellobot@users.noreply.github.com> * Suppress CA1861 Suppress CA1861 warnings in sample application. * Add null checks Ensure that elements aren't null. * Ensure tracks are visible Try ensuring the elements are visible before returning them to the test code. * Disable Dynamic PGO Disable Dynamic PGO to work around dotnet/runtime#87628. --------- Signed-off-by: costellobot <102549341+costellobot@users.noreply.github.com> Co-authored-by: Martin Costello <martin@martincostello.com>
* Update .NET SDK Update .NET SDK to version 8.0.100-preview.5.23303.2. --- updated-dependencies: - dependency-name: Microsoft.NET.Sdk dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: costellobot <102549341+costellobot@users.noreply.github.com> * Bump .NET NuGet packages Bumps .NET dependencies to their latest versions for the .NET 8.0.100-preview.5.23303.2 SDK. Bumps Microsoft.AspNetCore.Authentication.Facebook from 8.0.0-preview.4.23260.4 to 8.0.0-preview.5.23302.2. Bumps Microsoft.AspNetCore.Authentication.Google from 8.0.0-preview.4.23260.4 to 8.0.0-preview.5.23302.2. Bumps Microsoft.AspNetCore.Authentication.MicrosoftAccount from 8.0.0-preview.4.23260.4 to 8.0.0-preview.5.23302.2. Bumps Microsoft.AspNetCore.Authentication.Twitter from 8.0.0-preview.4.23260.4 to 8.0.0-preview.5.23302.2. Bumps Microsoft.AspNetCore.AzureAppServices.HostingStartup from 8.0.0-preview.4.23260.4 to 8.0.0-preview.5.23302.2. Bumps Microsoft.AspNetCore.Mvc.Testing from 8.0.0-preview.4.23260.4 to 8.0.0-preview.5.23302.2. Bumps Microsoft.Extensions.Http.Polly from 8.0.0-preview.4.23260.4 to 8.0.0-preview.5.23302.2. --- updated-dependencies: - dependency-name: Microsoft.AspNetCore.Authentication.Facebook dependency-type: direct:production update-type: version-update:semver-major - dependency-name: Microsoft.AspNetCore.Authentication.Google dependency-type: direct:production update-type: version-update:semver-major - dependency-name: Microsoft.AspNetCore.Authentication.MicrosoftAccount dependency-type: direct:production update-type: version-update:semver-major - dependency-name: Microsoft.AspNetCore.Authentication.Twitter dependency-type: direct:production update-type: version-update:semver-major - dependency-name: Microsoft.AspNetCore.AzureAppServices.HostingStartup dependency-type: direct:production update-type: version-update:semver-major - dependency-name: Microsoft.AspNetCore.Mvc.Testing dependency-type: direct:production update-type: version-update:semver-major - dependency-name: Microsoft.Extensions.Http.Polly dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: costellobot <102549341+costellobot@users.noreply.github.com> * Fix CA1861 warnings Fix (or suppress) new `CA1861` warnings. * Disable Dynamic PGO Disable Dynamic PGO to work around dotnet/runtime#87628. --------- Signed-off-by: costellobot <102549341+costellobot@users.noreply.github.com> Co-authored-by: martincostello <martin@martincostello.com>
* Update .NET SDK Update .NET SDK to version 8.0.100-preview.5.23303.2. --- updated-dependencies: - dependency-name: Microsoft.NET.Sdk dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: costellobot <102549341+costellobot@users.noreply.github.com> * Bump Microsoft.AspNetCore.Mvc.Testing from 8.0.0-preview.4.23260.4 to 8.0.0-preview.5.23302.2 Bumps Microsoft.AspNetCore.Mvc.Testing from 8.0.0-preview.4.23260.4 to 8.0.0-preview.5.23302.2. --- updated-dependencies: - dependency-name: Microsoft.AspNetCore.Mvc.Testing dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: costellobot <102549341+costellobot@users.noreply.github.com> * Suppress CA1861 Suppress CA1861 warnings in tests. * Use TimeProvider User `TimeProvider` to fix obsolete warning for `ISystemClock`. * Disable Dynamic PGO Disable Dynamic PGO to work around dotnet/runtime#87628. --------- Signed-off-by: costellobot <102549341+costellobot@users.noreply.github.com> Co-authored-by: martincostello <martin@martincostello.com>
* Update .NET SDK Update .NET SDK to version 8.0.100-preview.5.23303.2. --- updated-dependencies: - dependency-name: Microsoft.NET.Sdk dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: costellobot <102549341+costellobot@users.noreply.github.com> * Bump Microsoft.AspNetCore.Mvc.Testing from 8.0.0-preview.4.23260.4 to 8.0.0-preview.5.23302.2 Bumps Microsoft.AspNetCore.Mvc.Testing from 8.0.0-preview.4.23260.4 to 8.0.0-preview.5.23302.2. --- updated-dependencies: - dependency-name: Microsoft.AspNetCore.Mvc.Testing dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: costellobot <102549341+costellobot@users.noreply.github.com> * Suppress CA1861 Suppress CA1861 warnings in tests. * Use TimeProvider User `TimeProvider` to fix obsolete warning for `ISystemClock`. * Disable Dynamic PGO Disable Dynamic PGO to work around dotnet/runtime#87628. --------- Signed-off-by: costellobot <102549341+costellobot@users.noreply.github.com> Co-authored-by: martincostello <martin@martincostello.com>
* Update .NET SDK Update .NET SDK to version 8.0.100-preview.5.23303.2. --- updated-dependencies: - dependency-name: Microsoft.NET.Sdk dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: costellobot <102549341+costellobot@users.noreply.github.com> * Bump .NET NuGet packages Bumps .NET dependencies to their latest versions for the .NET 8.0.100-preview.5.23303.2 SDK. Bumps Microsoft.AspNetCore.Mvc.Testing from 8.0.0-preview.4.23260.4 to 8.0.0-preview.5.23302.2. Bumps Microsoft.EntityFrameworkCore.Sqlite from 8.0.0-preview.4.23259.3 to 8.0.0-preview.5.23280.1. --- updated-dependencies: - dependency-name: Microsoft.AspNetCore.Mvc.Testing dependency-type: direct:production update-type: version-update:semver-major - dependency-name: Microsoft.EntityFrameworkCore.Sqlite dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: costellobot <102549341+costellobot@users.noreply.github.com> * Suppress CA1861 Suppress CA1861 warnings in sample application. * Add null checks Ensure that elements aren't null. * Ensure tracks are visible Try ensuring the elements are visible before returning them to the test code. * Disable Dynamic PGO Disable Dynamic PGO to work around dotnet/runtime#87628. --------- Signed-off-by: costellobot <102549341+costellobot@users.noreply.github.com> Co-authored-by: Martin Costello <martin@martincostello.com>
* Update .NET SDK Update .NET SDK to version 8.0.100-preview.5.23303.2. --- updated-dependencies: - dependency-name: Microsoft.NET.Sdk dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: costellobot <102549341+costellobot@users.noreply.github.com> * Bump .NET NuGet packages Bumps .NET dependencies to their latest versions for the .NET 8.0.100-preview.5.23303.2 SDK. Bumps Microsoft.AspNetCore.Authentication.Facebook from 8.0.0-preview.4.23260.4 to 8.0.0-preview.5.23302.2. Bumps Microsoft.AspNetCore.Authentication.Google from 8.0.0-preview.4.23260.4 to 8.0.0-preview.5.23302.2. Bumps Microsoft.AspNetCore.Authentication.MicrosoftAccount from 8.0.0-preview.4.23260.4 to 8.0.0-preview.5.23302.2. Bumps Microsoft.AspNetCore.Authentication.Twitter from 8.0.0-preview.4.23260.4 to 8.0.0-preview.5.23302.2. Bumps Microsoft.AspNetCore.AzureAppServices.HostingStartup from 8.0.0-preview.4.23260.4 to 8.0.0-preview.5.23302.2. Bumps Microsoft.AspNetCore.Mvc.Testing from 8.0.0-preview.4.23260.4 to 8.0.0-preview.5.23302.2. Bumps Microsoft.Extensions.Http.Polly from 8.0.0-preview.4.23260.4 to 8.0.0-preview.5.23302.2. --- updated-dependencies: - dependency-name: Microsoft.AspNetCore.Authentication.Facebook dependency-type: direct:production update-type: version-update:semver-major - dependency-name: Microsoft.AspNetCore.Authentication.Google dependency-type: direct:production update-type: version-update:semver-major - dependency-name: Microsoft.AspNetCore.Authentication.MicrosoftAccount dependency-type: direct:production update-type: version-update:semver-major - dependency-name: Microsoft.AspNetCore.Authentication.Twitter dependency-type: direct:production update-type: version-update:semver-major - dependency-name: Microsoft.AspNetCore.AzureAppServices.HostingStartup dependency-type: direct:production update-type: version-update:semver-major - dependency-name: Microsoft.AspNetCore.Mvc.Testing dependency-type: direct:production update-type: version-update:semver-major - dependency-name: Microsoft.Extensions.Http.Polly dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: costellobot <102549341+costellobot@users.noreply.github.com> * Fix CA1861 warnings Fix (or suppress) new `CA1861` warnings. * Disable Dynamic PGO Disable Dynamic PGO to work around dotnet/runtime#87628. --------- Signed-off-by: costellobot <102549341+costellobot@users.noreply.github.com> Co-authored-by: martincostello <martin@martincostello.com>
* Update .NET SDK Update .NET SDK to version 8.0.100-preview.5.23303.2. --- updated-dependencies: - dependency-name: Microsoft.NET.Sdk dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: costellobot <102549341+costellobot@users.noreply.github.com> * Bump .NET NuGet packages Bumps .NET dependencies to their latest versions for the .NET 8.0.100-preview.5.23303.2 SDK. Bumps Microsoft.AspNetCore.Mvc.Testing from 8.0.0-preview.4.23260.4 to 8.0.0-preview.5.23302.2. Bumps Microsoft.EntityFrameworkCore.Sqlite from 8.0.0-preview.4.23259.3 to 8.0.0-preview.5.23280.1. --- updated-dependencies: - dependency-name: Microsoft.AspNetCore.Mvc.Testing dependency-type: direct:production update-type: version-update:semver-major - dependency-name: Microsoft.EntityFrameworkCore.Sqlite dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: costellobot <102549341+costellobot@users.noreply.github.com> * Suppress CA1861 Suppress CA1861 warnings in sample application. * Add null checks Ensure that elements aren't null. * Ensure tracks are visible Try ensuring the elements are visible before returning them to the test code. * Disable Dynamic PGO Disable Dynamic PGO to work around dotnet/runtime#87628. --------- Signed-off-by: costellobot <102549341+costellobot@users.noreply.github.com> Co-authored-by: Martin Costello <martin@martincostello.com>
* Update .NET SDK Update .NET SDK to version 8.0.100-preview.5.23303.2. --- updated-dependencies: - dependency-name: Microsoft.NET.Sdk dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: costellobot <102549341+costellobot@users.noreply.github.com> * Bump .NET NuGet packages Bumps .NET dependencies to their latest versions for the .NET 8.0.100-preview.5.23303.2 SDK. Bumps Microsoft.AspNetCore.Authentication.Facebook from 8.0.0-preview.4.23260.4 to 8.0.0-preview.5.23302.2. Bumps Microsoft.AspNetCore.Authentication.Google from 8.0.0-preview.4.23260.4 to 8.0.0-preview.5.23302.2. Bumps Microsoft.AspNetCore.Authentication.MicrosoftAccount from 8.0.0-preview.4.23260.4 to 8.0.0-preview.5.23302.2. Bumps Microsoft.AspNetCore.Authentication.Twitter from 8.0.0-preview.4.23260.4 to 8.0.0-preview.5.23302.2. Bumps Microsoft.AspNetCore.AzureAppServices.HostingStartup from 8.0.0-preview.4.23260.4 to 8.0.0-preview.5.23302.2. Bumps Microsoft.AspNetCore.Mvc.Testing from 8.0.0-preview.4.23260.4 to 8.0.0-preview.5.23302.2. Bumps Microsoft.Extensions.Http.Polly from 8.0.0-preview.4.23260.4 to 8.0.0-preview.5.23302.2. --- updated-dependencies: - dependency-name: Microsoft.AspNetCore.Authentication.Facebook dependency-type: direct:production update-type: version-update:semver-major - dependency-name: Microsoft.AspNetCore.Authentication.Google dependency-type: direct:production update-type: version-update:semver-major - dependency-name: Microsoft.AspNetCore.Authentication.MicrosoftAccount dependency-type: direct:production update-type: version-update:semver-major - dependency-name: Microsoft.AspNetCore.Authentication.Twitter dependency-type: direct:production update-type: version-update:semver-major - dependency-name: Microsoft.AspNetCore.AzureAppServices.HostingStartup dependency-type: direct:production update-type: version-update:semver-major - dependency-name: Microsoft.AspNetCore.Mvc.Testing dependency-type: direct:production update-type: version-update:semver-major - dependency-name: Microsoft.Extensions.Http.Polly dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: costellobot <102549341+costellobot@users.noreply.github.com> * Fix CA1861 warnings Fix (or suppress) new `CA1861` warnings. * Disable Dynamic PGO Disable Dynamic PGO to work around dotnet/runtime#87628. --------- Signed-off-by: costellobot <102549341+costellobot@users.noreply.github.com> Co-authored-by: martincostello <martin@martincostello.com>
* Update .NET SDK Update .NET SDK to version 8.0.100-preview.5.23303.2. --- updated-dependencies: - dependency-name: Microsoft.NET.Sdk dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: costellobot <102549341+costellobot@users.noreply.github.com> * Bump Microsoft.AspNetCore.Mvc.Testing from 8.0.0-preview.4.23260.4 to 8.0.0-preview.5.23302.2 Bumps Microsoft.AspNetCore.Mvc.Testing from 8.0.0-preview.4.23260.4 to 8.0.0-preview.5.23302.2. --- updated-dependencies: - dependency-name: Microsoft.AspNetCore.Mvc.Testing dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: costellobot <102549341+costellobot@users.noreply.github.com> * Suppress CA1861 Suppress CA1861 warnings in tests. * Use TimeProvider User `TimeProvider` to fix obsolete warning for `ISystemClock`. * Disable Dynamic PGO Disable Dynamic PGO to work around dotnet/runtime#87628. --------- Signed-off-by: costellobot <102549341+costellobot@users.noreply.github.com> Co-authored-by: martincostello <martin@martincostello.com>
* Update .NET SDK Update .NET SDK to version 8.0.100-preview.5.23303.2. --- updated-dependencies: - dependency-name: Microsoft.NET.Sdk dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: costellobot <102549341+costellobot@users.noreply.github.com> * Bump .NET NuGet packages Bumps .NET dependencies to their latest versions for the .NET 8.0.100-preview.5.23303.2 SDK. Bumps Microsoft.AspNetCore.Authentication.Facebook from 8.0.0-preview.4.23260.4 to 8.0.0-preview.5.23302.2. Bumps Microsoft.AspNetCore.Authentication.Google from 8.0.0-preview.4.23260.4 to 8.0.0-preview.5.23302.2. Bumps Microsoft.AspNetCore.Authentication.MicrosoftAccount from 8.0.0-preview.4.23260.4 to 8.0.0-preview.5.23302.2. Bumps Microsoft.AspNetCore.Authentication.Twitter from 8.0.0-preview.4.23260.4 to 8.0.0-preview.5.23302.2. Bumps Microsoft.AspNetCore.AzureAppServices.HostingStartup from 8.0.0-preview.4.23260.4 to 8.0.0-preview.5.23302.2. Bumps Microsoft.AspNetCore.Mvc.Testing from 8.0.0-preview.4.23260.4 to 8.0.0-preview.5.23302.2. Bumps Microsoft.Extensions.Http.Polly from 8.0.0-preview.4.23260.4 to 8.0.0-preview.5.23302.2. --- updated-dependencies: - dependency-name: Microsoft.AspNetCore.Authentication.Facebook dependency-type: direct:production update-type: version-update:semver-major - dependency-name: Microsoft.AspNetCore.Authentication.Google dependency-type: direct:production update-type: version-update:semver-major - dependency-name: Microsoft.AspNetCore.Authentication.MicrosoftAccount dependency-type: direct:production update-type: version-update:semver-major - dependency-name: Microsoft.AspNetCore.Authentication.Twitter dependency-type: direct:production update-type: version-update:semver-major - dependency-name: Microsoft.AspNetCore.AzureAppServices.HostingStartup dependency-type: direct:production update-type: version-update:semver-major - dependency-name: Microsoft.AspNetCore.Mvc.Testing dependency-type: direct:production update-type: version-update:semver-major - dependency-name: Microsoft.Extensions.Http.Polly dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: costellobot <102549341+costellobot@users.noreply.github.com> * Fix CA1861 warnings Fix (or suppress) new `CA1861` warnings. * Disable Dynamic PGO Disable Dynamic PGO to work around dotnet/runtime#87628. --------- Signed-off-by: costellobot <102549341+costellobot@users.noreply.github.com> Co-authored-by: martincostello <martin@martincostello.com>
* Update .NET SDK Update .NET SDK to version 8.0.100-preview.5.23303.2. --- updated-dependencies: - dependency-name: Microsoft.NET.Sdk dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: costellobot <102549341+costellobot@users.noreply.github.com> * Bump .NET NuGet packages Bumps .NET dependencies to their latest versions for the .NET 8.0.100-preview.5.23303.2 SDK. Bumps Microsoft.AspNetCore.Mvc.Testing from 8.0.0-preview.4.23260.4 to 8.0.0-preview.5.23302.2. Bumps Microsoft.EntityFrameworkCore.Sqlite from 8.0.0-preview.4.23259.3 to 8.0.0-preview.5.23280.1. --- updated-dependencies: - dependency-name: Microsoft.AspNetCore.Mvc.Testing dependency-type: direct:production update-type: version-update:semver-major - dependency-name: Microsoft.EntityFrameworkCore.Sqlite dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: costellobot <102549341+costellobot@users.noreply.github.com> * Suppress CA1861 Suppress CA1861 warnings in sample application. * Add null checks Ensure that elements aren't null. * Ensure tracks are visible Try ensuring the elements are visible before returning them to the test code. * Disable Dynamic PGO Disable Dynamic PGO to work around dotnet/runtime#87628. --------- Signed-off-by: costellobot <102549341+costellobot@users.noreply.github.com> Co-authored-by: Martin Costello <martin@martincostello.com>
* Update .NET SDK Update .NET SDK to version 8.0.100-preview.5.23303.2. --- updated-dependencies: - dependency-name: Microsoft.NET.Sdk dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: costellobot <102549341+costellobot@users.noreply.github.com> * Bump Microsoft.AspNetCore.Mvc.Testing from 8.0.0-preview.4.23260.4 to 8.0.0-preview.5.23302.2 Bumps Microsoft.AspNetCore.Mvc.Testing from 8.0.0-preview.4.23260.4 to 8.0.0-preview.5.23302.2. --- updated-dependencies: - dependency-name: Microsoft.AspNetCore.Mvc.Testing dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: costellobot <102549341+costellobot@users.noreply.github.com> * Suppress CA1861 Suppress CA1861 warnings in tests. * Use TimeProvider User `TimeProvider` to fix obsolete warning for `ISystemClock`. * Disable Dynamic PGO Disable Dynamic PGO to work around dotnet/runtime#87628. --------- Signed-off-by: costellobot <102549341+costellobot@users.noreply.github.com> Co-authored-by: martincostello <martin@martincostello.com>
* Update .NET SDK Update .NET SDK to version 8.0.100-preview.5.23303.2. --- updated-dependencies: - dependency-name: Microsoft.NET.Sdk dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: costellobot <102549341+costellobot@users.noreply.github.com> * Bump .NET NuGet packages Bumps .NET dependencies to their latest versions for the .NET 8.0.100-preview.5.23303.2 SDK. Bumps Microsoft.AspNetCore.Authentication.Facebook from 8.0.0-preview.4.23260.4 to 8.0.0-preview.5.23302.2. Bumps Microsoft.AspNetCore.Authentication.Google from 8.0.0-preview.4.23260.4 to 8.0.0-preview.5.23302.2. Bumps Microsoft.AspNetCore.Authentication.MicrosoftAccount from 8.0.0-preview.4.23260.4 to 8.0.0-preview.5.23302.2. Bumps Microsoft.AspNetCore.Authentication.Twitter from 8.0.0-preview.4.23260.4 to 8.0.0-preview.5.23302.2. Bumps Microsoft.AspNetCore.AzureAppServices.HostingStartup from 8.0.0-preview.4.23260.4 to 8.0.0-preview.5.23302.2. Bumps Microsoft.AspNetCore.Mvc.Testing from 8.0.0-preview.4.23260.4 to 8.0.0-preview.5.23302.2. Bumps Microsoft.Extensions.Http.Polly from 8.0.0-preview.4.23260.4 to 8.0.0-preview.5.23302.2. --- updated-dependencies: - dependency-name: Microsoft.AspNetCore.Authentication.Facebook dependency-type: direct:production update-type: version-update:semver-major - dependency-name: Microsoft.AspNetCore.Authentication.Google dependency-type: direct:production update-type: version-update:semver-major - dependency-name: Microsoft.AspNetCore.Authentication.MicrosoftAccount dependency-type: direct:production update-type: version-update:semver-major - dependency-name: Microsoft.AspNetCore.Authentication.Twitter dependency-type: direct:production update-type: version-update:semver-major - dependency-name: Microsoft.AspNetCore.AzureAppServices.HostingStartup dependency-type: direct:production update-type: version-update:semver-major - dependency-name: Microsoft.AspNetCore.Mvc.Testing dependency-type: direct:production update-type: version-update:semver-major - dependency-name: Microsoft.Extensions.Http.Polly dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: costellobot <102549341+costellobot@users.noreply.github.com> * Fix CA1861 warnings Fix (or suppress) new `CA1861` warnings. * Disable Dynamic PGO Disable Dynamic PGO to work around dotnet/runtime#87628. --------- Signed-off-by: costellobot <102549341+costellobot@users.noreply.github.com> Co-authored-by: martincostello <martin@martincostello.com>
* Update .NET SDK Update .NET SDK to version 8.0.100-preview.5.23303.2. --- updated-dependencies: - dependency-name: Microsoft.NET.Sdk dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: costellobot <102549341+costellobot@users.noreply.github.com> * Bump .NET NuGet packages Bumps .NET dependencies to their latest versions for the .NET 8.0.100-preview.5.23303.2 SDK. Bumps Microsoft.AspNetCore.Mvc.Testing from 8.0.0-preview.4.23260.4 to 8.0.0-preview.5.23302.2. Bumps Microsoft.EntityFrameworkCore.Sqlite from 8.0.0-preview.4.23259.3 to 8.0.0-preview.5.23280.1. --- updated-dependencies: - dependency-name: Microsoft.AspNetCore.Mvc.Testing dependency-type: direct:production update-type: version-update:semver-major - dependency-name: Microsoft.EntityFrameworkCore.Sqlite dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: costellobot <102549341+costellobot@users.noreply.github.com> * Suppress CA1861 Suppress CA1861 warnings in sample application. * Add null checks Ensure that elements aren't null. * Ensure tracks are visible Try ensuring the elements are visible before returning them to the test code. * Disable Dynamic PGO Disable Dynamic PGO to work around dotnet/runtime#87628. --------- Signed-off-by: costellobot <102549341+costellobot@users.noreply.github.com> Co-authored-by: Martin Costello <martin@martincostello.com>
* Update .NET SDK Update .NET SDK to version 8.0.100-preview.5.23303.2. --- updated-dependencies: - dependency-name: Microsoft.NET.Sdk dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: costellobot <102549341+costellobot@users.noreply.github.com> * Bump Microsoft.AspNetCore.Mvc.Testing from 8.0.0-preview.4.23260.4 to 8.0.0-preview.5.23302.2 Bumps Microsoft.AspNetCore.Mvc.Testing from 8.0.0-preview.4.23260.4 to 8.0.0-preview.5.23302.2. --- updated-dependencies: - dependency-name: Microsoft.AspNetCore.Mvc.Testing dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: costellobot <102549341+costellobot@users.noreply.github.com> * Suppress CA1861 Suppress CA1861 warnings in tests. * Use TimeProvider User `TimeProvider` to fix obsolete warning for `ISystemClock`. * Disable Dynamic PGO Disable Dynamic PGO to work around dotnet/runtime#87628. --------- Signed-off-by: costellobot <102549341+costellobot@users.noreply.github.com> Co-authored-by: martincostello <martin@martincostello.com>
* Update .NET SDK Update .NET SDK to version 8.0.100-preview.5.23303.2. --- updated-dependencies: - dependency-name: Microsoft.NET.Sdk dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: costellobot <102549341+costellobot@users.noreply.github.com> * Bump .NET NuGet packages Bumps .NET dependencies to their latest versions for the .NET 8.0.100-preview.5.23303.2 SDK. Bumps Microsoft.AspNetCore.Mvc.Testing from 8.0.0-preview.4.23260.4 to 8.0.0-preview.5.23302.2. Bumps Microsoft.EntityFrameworkCore.Sqlite from 8.0.0-preview.4.23259.3 to 8.0.0-preview.5.23280.1. --- updated-dependencies: - dependency-name: Microsoft.AspNetCore.Mvc.Testing dependency-type: direct:production update-type: version-update:semver-major - dependency-name: Microsoft.EntityFrameworkCore.Sqlite dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: costellobot <102549341+costellobot@users.noreply.github.com> * Suppress CA1861 Suppress CA1861 warnings in sample application. * Add null checks Ensure that elements aren't null. * Ensure tracks are visible Try ensuring the elements are visible before returning them to the test code. * Disable Dynamic PGO Disable Dynamic PGO to work around dotnet/runtime#87628. --------- Signed-off-by: costellobot <102549341+costellobot@users.noreply.github.com> Co-authored-by: Martin Costello <martin@martincostello.com>
* Update .NET SDK Update .NET SDK to version 8.0.100-preview.5.23303.2. --- updated-dependencies: - dependency-name: Microsoft.NET.Sdk dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: costellobot <102549341+costellobot@users.noreply.github.com> * Bump .NET NuGet packages Bumps .NET dependencies to their latest versions for the .NET 8.0.100-preview.5.23303.2 SDK. Bumps Microsoft.AspNetCore.Authentication.Facebook from 8.0.0-preview.4.23260.4 to 8.0.0-preview.5.23302.2. Bumps Microsoft.AspNetCore.Authentication.Google from 8.0.0-preview.4.23260.4 to 8.0.0-preview.5.23302.2. Bumps Microsoft.AspNetCore.Authentication.MicrosoftAccount from 8.0.0-preview.4.23260.4 to 8.0.0-preview.5.23302.2. Bumps Microsoft.AspNetCore.Authentication.Twitter from 8.0.0-preview.4.23260.4 to 8.0.0-preview.5.23302.2. Bumps Microsoft.AspNetCore.AzureAppServices.HostingStartup from 8.0.0-preview.4.23260.4 to 8.0.0-preview.5.23302.2. Bumps Microsoft.AspNetCore.Mvc.Testing from 8.0.0-preview.4.23260.4 to 8.0.0-preview.5.23302.2. Bumps Microsoft.Extensions.Http.Polly from 8.0.0-preview.4.23260.4 to 8.0.0-preview.5.23302.2. --- updated-dependencies: - dependency-name: Microsoft.AspNetCore.Authentication.Facebook dependency-type: direct:production update-type: version-update:semver-major - dependency-name: Microsoft.AspNetCore.Authentication.Google dependency-type: direct:production update-type: version-update:semver-major - dependency-name: Microsoft.AspNetCore.Authentication.MicrosoftAccount dependency-type: direct:production update-type: version-update:semver-major - dependency-name: Microsoft.AspNetCore.Authentication.Twitter dependency-type: direct:production update-type: version-update:semver-major - dependency-name: Microsoft.AspNetCore.AzureAppServices.HostingStartup dependency-type: direct:production update-type: version-update:semver-major - dependency-name: Microsoft.AspNetCore.Mvc.Testing dependency-type: direct:production update-type: version-update:semver-major - dependency-name: Microsoft.Extensions.Http.Polly dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: costellobot <102549341+costellobot@users.noreply.github.com> * Fix CA1861 warnings Fix (or suppress) new `CA1861` warnings. * Disable Dynamic PGO Disable Dynamic PGO to work around dotnet/runtime#87628. --------- Signed-off-by: costellobot <102549341+costellobot@users.noreply.github.com> Co-authored-by: martincostello <martin@martincostello.com>
* Update .NET SDK Update .NET SDK to version 8.0.100-preview.5.23303.2. --- updated-dependencies: - dependency-name: Microsoft.NET.Sdk dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: costellobot <102549341+costellobot@users.noreply.github.com> * Bump .NET NuGet packages Bumps .NET dependencies to their latest versions for the .NET 8.0.100-preview.5.23303.2 SDK. Bumps Microsoft.AspNetCore.Mvc.Testing from 8.0.0-preview.4.23260.4 to 8.0.0-preview.5.23302.2. Bumps Microsoft.EntityFrameworkCore.Sqlite from 8.0.0-preview.4.23259.3 to 8.0.0-preview.5.23280.1. --- updated-dependencies: - dependency-name: Microsoft.AspNetCore.Mvc.Testing dependency-type: direct:production update-type: version-update:semver-major - dependency-name: Microsoft.EntityFrameworkCore.Sqlite dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: costellobot <102549341+costellobot@users.noreply.github.com> * Suppress CA1861 Suppress CA1861 warnings in sample application. * Add null checks Ensure that elements aren't null. * Ensure tracks are visible Try ensuring the elements are visible before returning them to the test code. * Disable Dynamic PGO Disable Dynamic PGO to work around dotnet/runtime#87628. --------- Signed-off-by: costellobot <102549341+costellobot@users.noreply.github.com> Co-authored-by: Martin Costello <martin@martincostello.com>
* Update .NET SDK Update .NET SDK to version 8.0.100-preview.5.23303.2. --- updated-dependencies: - dependency-name: Microsoft.NET.Sdk dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: costellobot <102549341+costellobot@users.noreply.github.com> * Bump .NET NuGet packages Bumps .NET dependencies to their latest versions for the .NET 8.0.100-preview.5.23303.2 SDK. Bumps Microsoft.AspNetCore.Authentication.Facebook from 8.0.0-preview.4.23260.4 to 8.0.0-preview.5.23302.2. Bumps Microsoft.AspNetCore.Authentication.Google from 8.0.0-preview.4.23260.4 to 8.0.0-preview.5.23302.2. Bumps Microsoft.AspNetCore.Authentication.MicrosoftAccount from 8.0.0-preview.4.23260.4 to 8.0.0-preview.5.23302.2. Bumps Microsoft.AspNetCore.Authentication.Twitter from 8.0.0-preview.4.23260.4 to 8.0.0-preview.5.23302.2. Bumps Microsoft.AspNetCore.AzureAppServices.HostingStartup from 8.0.0-preview.4.23260.4 to 8.0.0-preview.5.23302.2. Bumps Microsoft.AspNetCore.Mvc.Testing from 8.0.0-preview.4.23260.4 to 8.0.0-preview.5.23302.2. Bumps Microsoft.Extensions.Http.Polly from 8.0.0-preview.4.23260.4 to 8.0.0-preview.5.23302.2. --- updated-dependencies: - dependency-name: Microsoft.AspNetCore.Authentication.Facebook dependency-type: direct:production update-type: version-update:semver-major - dependency-name: Microsoft.AspNetCore.Authentication.Google dependency-type: direct:production update-type: version-update:semver-major - dependency-name: Microsoft.AspNetCore.Authentication.MicrosoftAccount dependency-type: direct:production update-type: version-update:semver-major - dependency-name: Microsoft.AspNetCore.Authentication.Twitter dependency-type: direct:production update-type: version-update:semver-major - dependency-name: Microsoft.AspNetCore.AzureAppServices.HostingStartup dependency-type: direct:production update-type: version-update:semver-major - dependency-name: Microsoft.AspNetCore.Mvc.Testing dependency-type: direct:production update-type: version-update:semver-major - dependency-name: Microsoft.Extensions.Http.Polly dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: costellobot <102549341+costellobot@users.noreply.github.com> * Fix CA1861 warnings Fix (or suppress) new `CA1861` warnings. * Disable Dynamic PGO Disable Dynamic PGO to work around dotnet/runtime#87628. --------- Signed-off-by: costellobot <102549341+costellobot@users.noreply.github.com> Co-authored-by: martincostello <martin@martincostello.com>
* Update .NET SDK Update .NET SDK to version 8.0.100-preview.5.23303.2. --- updated-dependencies: - dependency-name: Microsoft.NET.Sdk dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: costellobot <102549341+costellobot@users.noreply.github.com> * Bump Microsoft.AspNetCore.Mvc.Testing from 8.0.0-preview.4.23260.4 to 8.0.0-preview.5.23302.2 Bumps Microsoft.AspNetCore.Mvc.Testing from 8.0.0-preview.4.23260.4 to 8.0.0-preview.5.23302.2. --- updated-dependencies: - dependency-name: Microsoft.AspNetCore.Mvc.Testing dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: costellobot <102549341+costellobot@users.noreply.github.com> * Suppress CA1861 Suppress CA1861 warnings in tests. * Use TimeProvider User `TimeProvider` to fix obsolete warning for `ISystemClock`. * Disable Dynamic PGO Disable Dynamic PGO to work around dotnet/runtime#87628. --------- Signed-off-by: costellobot <102549341+costellobot@users.noreply.github.com> Co-authored-by: martincostello <martin@martincostello.com>
* Update .NET SDK Update .NET SDK to version 8.0.100-preview.5.23303.2. --- updated-dependencies: - dependency-name: Microsoft.NET.Sdk dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: costellobot <102549341+costellobot@users.noreply.github.com> * Bump .NET NuGet packages Bumps .NET dependencies to their latest versions for the .NET 8.0.100-preview.5.23303.2 SDK. Bumps Microsoft.AspNetCore.Mvc.Testing from 8.0.0-preview.4.23260.4 to 8.0.0-preview.5.23302.2. Bumps Microsoft.EntityFrameworkCore.Sqlite from 8.0.0-preview.4.23259.3 to 8.0.0-preview.5.23280.1. --- updated-dependencies: - dependency-name: Microsoft.AspNetCore.Mvc.Testing dependency-type: direct:production update-type: version-update:semver-major - dependency-name: Microsoft.EntityFrameworkCore.Sqlite dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: costellobot <102549341+costellobot@users.noreply.github.com> * Suppress CA1861 Suppress CA1861 warnings in sample application. * Add null checks Ensure that elements aren't null. * Ensure tracks are visible Try ensuring the elements are visible before returning them to the test code. * Disable Dynamic PGO Disable Dynamic PGO to work around dotnet/runtime#87628. --------- Signed-off-by: costellobot <102549341+costellobot@users.noreply.github.com> Co-authored-by: Martin Costello <martin@martincostello.com>
* Update .NET SDK Update .NET SDK to version 8.0.100-preview.5.23303.2. --- updated-dependencies: - dependency-name: Microsoft.NET.Sdk dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: costellobot <102549341+costellobot@users.noreply.github.com> * Bump .NET NuGet packages Bumps .NET dependencies to their latest versions for the .NET 8.0.100-preview.5.23303.2 SDK. Bumps Microsoft.AspNetCore.Authentication.Facebook from 8.0.0-preview.4.23260.4 to 8.0.0-preview.5.23302.2. Bumps Microsoft.AspNetCore.Authentication.Google from 8.0.0-preview.4.23260.4 to 8.0.0-preview.5.23302.2. Bumps Microsoft.AspNetCore.Authentication.MicrosoftAccount from 8.0.0-preview.4.23260.4 to 8.0.0-preview.5.23302.2. Bumps Microsoft.AspNetCore.Authentication.Twitter from 8.0.0-preview.4.23260.4 to 8.0.0-preview.5.23302.2. Bumps Microsoft.AspNetCore.AzureAppServices.HostingStartup from 8.0.0-preview.4.23260.4 to 8.0.0-preview.5.23302.2. Bumps Microsoft.AspNetCore.Mvc.Testing from 8.0.0-preview.4.23260.4 to 8.0.0-preview.5.23302.2. Bumps Microsoft.Extensions.Http.Polly from 8.0.0-preview.4.23260.4 to 8.0.0-preview.5.23302.2. --- updated-dependencies: - dependency-name: Microsoft.AspNetCore.Authentication.Facebook dependency-type: direct:production update-type: version-update:semver-major - dependency-name: Microsoft.AspNetCore.Authentication.Google dependency-type: direct:production update-type: version-update:semver-major - dependency-name: Microsoft.AspNetCore.Authentication.MicrosoftAccount dependency-type: direct:production update-type: version-update:semver-major - dependency-name: Microsoft.AspNetCore.Authentication.Twitter dependency-type: direct:production update-type: version-update:semver-major - dependency-name: Microsoft.AspNetCore.AzureAppServices.HostingStartup dependency-type: direct:production update-type: version-update:semver-major - dependency-name: Microsoft.AspNetCore.Mvc.Testing dependency-type: direct:production update-type: version-update:semver-major - dependency-name: Microsoft.Extensions.Http.Polly dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: costellobot <102549341+costellobot@users.noreply.github.com> * Fix CA1861 warnings Fix (or suppress) new `CA1861` warnings. * Disable Dynamic PGO Disable Dynamic PGO to work around dotnet/runtime#87628. --------- Signed-off-by: costellobot <102549341+costellobot@users.noreply.github.com> Co-authored-by: martincostello <martin@martincostello.com>
* Update .NET SDK Update .NET SDK to version 8.0.100-preview.5.23303.2. --- updated-dependencies: - dependency-name: Microsoft.NET.Sdk dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: costellobot <102549341+costellobot@users.noreply.github.com> * Bump Microsoft.AspNetCore.Mvc.Testing from 8.0.0-preview.4.23260.4 to 8.0.0-preview.5.23302.2 Bumps Microsoft.AspNetCore.Mvc.Testing from 8.0.0-preview.4.23260.4 to 8.0.0-preview.5.23302.2. --- updated-dependencies: - dependency-name: Microsoft.AspNetCore.Mvc.Testing dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: costellobot <102549341+costellobot@users.noreply.github.com> * Suppress CA1861 Suppress CA1861 warnings in tests. * Use TimeProvider User `TimeProvider` to fix obsolete warning for `ISystemClock`. * Disable Dynamic PGO Disable Dynamic PGO to work around dotnet/runtime#87628. --------- Signed-off-by: costellobot <102549341+costellobot@users.noreply.github.com> Co-authored-by: martincostello <martin@martincostello.com>
* Update .NET SDK Update .NET SDK to version 8.0.100-preview.5.23303.2. --- updated-dependencies: - dependency-name: Microsoft.NET.Sdk dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: costellobot <102549341+costellobot@users.noreply.github.com> * Bump .NET NuGet packages Bumps .NET dependencies to their latest versions for the .NET 8.0.100-preview.5.23303.2 SDK. Bumps Microsoft.AspNetCore.Mvc.Testing from 8.0.0-preview.4.23260.4 to 8.0.0-preview.5.23302.2. Bumps Microsoft.EntityFrameworkCore.Sqlite from 8.0.0-preview.4.23259.3 to 8.0.0-preview.5.23280.1. --- updated-dependencies: - dependency-name: Microsoft.AspNetCore.Mvc.Testing dependency-type: direct:production update-type: version-update:semver-major - dependency-name: Microsoft.EntityFrameworkCore.Sqlite dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: costellobot <102549341+costellobot@users.noreply.github.com> * Suppress CA1861 Suppress CA1861 warnings in sample application. * Add null checks Ensure that elements aren't null. * Ensure tracks are visible Try ensuring the elements are visible before returning them to the test code. * Disable Dynamic PGO Disable Dynamic PGO to work around dotnet/runtime#87628. --------- Signed-off-by: costellobot <102549341+costellobot@users.noreply.github.com> Co-authored-by: Martin Costello <martin@martincostello.com>
* Update .NET SDK Update .NET SDK to version 8.0.100-preview.5.23303.2. --- updated-dependencies: - dependency-name: Microsoft.NET.Sdk dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: costellobot <102549341+costellobot@users.noreply.github.com> * Bump Microsoft.AspNetCore.Mvc.Testing from 8.0.0-preview.4.23260.4 to 8.0.0-preview.5.23302.2 Bumps Microsoft.AspNetCore.Mvc.Testing from 8.0.0-preview.4.23260.4 to 8.0.0-preview.5.23302.2. --- updated-dependencies: - dependency-name: Microsoft.AspNetCore.Mvc.Testing dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: costellobot <102549341+costellobot@users.noreply.github.com> * Suppress CA1861 Suppress CA1861 warnings in tests. * Use TimeProvider User `TimeProvider` to fix obsolete warning for `ISystemClock`. * Disable Dynamic PGO Disable Dynamic PGO to work around dotnet/runtime#87628. --------- Signed-off-by: costellobot <102549341+costellobot@users.noreply.github.com> Co-authored-by: martincostello <martin@martincostello.com>
* Update .NET SDK Update .NET SDK to version 8.0.100-preview.5.23303.2. --- updated-dependencies: - dependency-name: Microsoft.NET.Sdk dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: costellobot <102549341+costellobot@users.noreply.github.com> * Bump .NET NuGet packages Bumps .NET dependencies to their latest versions for the .NET 8.0.100-preview.5.23303.2 SDK. Bumps Microsoft.AspNetCore.Authentication.Facebook from 8.0.0-preview.4.23260.4 to 8.0.0-preview.5.23302.2. Bumps Microsoft.AspNetCore.Authentication.Google from 8.0.0-preview.4.23260.4 to 8.0.0-preview.5.23302.2. Bumps Microsoft.AspNetCore.Authentication.MicrosoftAccount from 8.0.0-preview.4.23260.4 to 8.0.0-preview.5.23302.2. Bumps Microsoft.AspNetCore.Authentication.Twitter from 8.0.0-preview.4.23260.4 to 8.0.0-preview.5.23302.2. Bumps Microsoft.AspNetCore.AzureAppServices.HostingStartup from 8.0.0-preview.4.23260.4 to 8.0.0-preview.5.23302.2. Bumps Microsoft.AspNetCore.Mvc.Testing from 8.0.0-preview.4.23260.4 to 8.0.0-preview.5.23302.2. Bumps Microsoft.Extensions.Http.Polly from 8.0.0-preview.4.23260.4 to 8.0.0-preview.5.23302.2. --- updated-dependencies: - dependency-name: Microsoft.AspNetCore.Authentication.Facebook dependency-type: direct:production update-type: version-update:semver-major - dependency-name: Microsoft.AspNetCore.Authentication.Google dependency-type: direct:production update-type: version-update:semver-major - dependency-name: Microsoft.AspNetCore.Authentication.MicrosoftAccount dependency-type: direct:production update-type: version-update:semver-major - dependency-name: Microsoft.AspNetCore.Authentication.Twitter dependency-type: direct:production update-type: version-update:semver-major - dependency-name: Microsoft.AspNetCore.AzureAppServices.HostingStartup dependency-type: direct:production update-type: version-update:semver-major - dependency-name: Microsoft.AspNetCore.Mvc.Testing dependency-type: direct:production update-type: version-update:semver-major - dependency-name: Microsoft.Extensions.Http.Polly dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: costellobot <102549341+costellobot@users.noreply.github.com> * Fix CA1861 warnings Fix (or suppress) new `CA1861` warnings. * Disable Dynamic PGO Disable Dynamic PGO to work around dotnet/runtime#87628. --------- Signed-off-by: costellobot <102549341+costellobot@users.noreply.github.com> Co-authored-by: martincostello <martin@martincostello.com>
* Update .NET SDK Update .NET SDK to version 8.0.100-preview.5.23303.2. --- updated-dependencies: - dependency-name: Microsoft.NET.Sdk dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: costellobot <102549341+costellobot@users.noreply.github.com> * Bump .NET NuGet packages Bumps .NET dependencies to their latest versions for the .NET 8.0.100-preview.5.23303.2 SDK. Bumps Microsoft.AspNetCore.Mvc.Testing from 8.0.0-preview.4.23260.4 to 8.0.0-preview.5.23302.2. Bumps Microsoft.EntityFrameworkCore.Sqlite from 8.0.0-preview.4.23259.3 to 8.0.0-preview.5.23280.1. --- updated-dependencies: - dependency-name: Microsoft.AspNetCore.Mvc.Testing dependency-type: direct:production update-type: version-update:semver-major - dependency-name: Microsoft.EntityFrameworkCore.Sqlite dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: costellobot <102549341+costellobot@users.noreply.github.com> * Suppress CA1861 Suppress CA1861 warnings in sample application. * Add null checks Ensure that elements aren't null. * Ensure tracks are visible Try ensuring the elements are visible before returning them to the test code. * Disable Dynamic PGO Disable Dynamic PGO to work around dotnet/runtime#87628. --------- Signed-off-by: costellobot <102549341+costellobot@users.noreply.github.com> Co-authored-by: Martin Costello <martin@martincostello.com>
* Update .NET SDK Update .NET SDK to version 8.0.100-preview.5.23303.2. --- updated-dependencies: - dependency-name: Microsoft.NET.Sdk dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: costellobot <102549341+costellobot@users.noreply.github.com> * Bump .NET NuGet packages Bumps .NET dependencies to their latest versions for the .NET 8.0.100-preview.5.23303.2 SDK. Bumps Microsoft.AspNetCore.Mvc.Testing from 8.0.0-preview.4.23260.4 to 8.0.0-preview.5.23302.2. Bumps Microsoft.EntityFrameworkCore.Sqlite from 8.0.0-preview.4.23259.3 to 8.0.0-preview.5.23280.1. --- updated-dependencies: - dependency-name: Microsoft.AspNetCore.Mvc.Testing dependency-type: direct:production update-type: version-update:semver-major - dependency-name: Microsoft.EntityFrameworkCore.Sqlite dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: costellobot <102549341+costellobot@users.noreply.github.com> * Suppress CA1861 Suppress CA1861 warnings in sample application. * Add null checks Ensure that elements aren't null. * Ensure tracks are visible Try ensuring the elements are visible before returning them to the test code. * Disable Dynamic PGO Disable Dynamic PGO to work around dotnet/runtime#87628. --------- Signed-off-by: costellobot <102549341+costellobot@users.noreply.github.com> Co-authored-by: Martin Costello <martin@martincostello.com>
Description
I have a number of applications that were targeting .NET 8 preview 4 that have been upgraded to .NET preview 5 this week. In four different applications (only 3 are public), I've observed issues with their UI tests that use Microsoft.Playwright where a
NullReferenceException
is thrown from within the Playwright code during test execution.These failures occur on Windows, macOS and Linux, but exactly what fails seems to vary slightly between the different applications and operating systems.
After doing various investigation, including debugging one of the applications consuming Microsoft.Playwright from source, I wonder if there's an issue somewhere related to
AsyncLocal<T>
and/orTaskCreationOptions.RunContinuationsAsynchronously
in .NET 8 preview 5? This is partly just a hunch as I've seen PRs into the repo recently around Task-related refactoring, I might be way off in my assessment.The code for the relevant parts of Playwright in v1.35.0 using these are here:
TaskCreationOptions.RunContinuationsAsynchronously
being usedNullReferenceException
comes from, which is accessing anAsyncLocal<T>
try-finally
block awaiting a delegate that is invoking theInnerSendMessageToServerAsync()
method containing the above codeWhen referencing the Playwright code from source I added the following lines before the
AsyncLocal<T>
is accessed:Re-running the tests with this edit changes the test failures to the following:
This seems to suggest to me that the
try-catch
which is editingApiZone.Value[0]
is not running in the execution order that is expected by the async calls. This is just my inference though at trying to explain away the exception - I'm not familiar with the inner workings of Playwright's implementation.Observing the UI tests with headless mode disabled (as well as reviewing screenshots and recordings) don't seem to suggest any issues with the applications themselves in terms of their expected behaviour (i.e. genuine test failures), it seems that something is just causing Playwright to fail internally.
An additional factor to me thinking this is something related to
AsyncLocal<T>
is that if I run an affected test which is data-driven and remove all of the browser combinations and just run a single browser (whatever that browser is), then the test passed on each of my attempts. Similarly, the same test may fail on different lines during the assertions, rather than always the exact same failure.Reproduction Steps
build.ps1 -TestFilter Can_Configure_Repositories
Expected behavior
The tests pass.
Actual behavior
One or more tests fail with an exception similar to the below:
Regression?
Yes. The test pass with .NET 7.0.7 and with .NET 8 preview 4.
Known Workarounds
None.
Configuration
8.0.100-preview.5.23303.2
Other information
No response
The text was updated successfully, but these errors were encountered: