Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Default interfaces] Interfaces implemented by arrays #9552

Closed
MichalStrehovsky opened this issue Jan 15, 2018 · 3 comments
Closed

[Default interfaces] Interfaces implemented by arrays #9552

MichalStrehovsky opened this issue Jan 15, 2018 · 3 comments

Comments

@MichalStrehovsky
Copy link
Member

@MichalStrehovsky MichalStrehovsky commented Jan 15, 2018

The way default interface methods got implemented in CoreCLR likely means we can't add default interface methods to any of the generic interfaces implemented by arrays.

@MichalStrehovsky
Copy link
Member Author

@MichalStrehovsky MichalStrehovsky commented Feb 12, 2018

This is rather difficult to test. CoreLib is not roundtrippable through ILDASM/ILASM (error : Invalid Get method of property 'FirstChar') so I can't really add a new default interface method to, say, ICollection<T>, and test it.

We should have a look at this when we pick up a version of Roslyn that supports default interface methods.

@msftgits msftgits transferred this issue from dotnet/coreclr Jan 31, 2020
@msftgits msftgits added this to the Future milestone Jan 31, 2020
@mangod9
Copy link
Member

@mangod9 mangod9 commented Sep 17, 2020

Hi @MichalStrehovsky is this still an issue post .net 5? Thx

@MichalStrehovsky
Copy link
Member Author

@MichalStrehovsky MichalStrehovsky commented Sep 17, 2020

Yes, but since this only affects interfaces that are 100% under our control, we can fix this if/when this becomes an issue (i.e. the libraries team decides it wants to add new methods to e.g. ICollection<T>).

@msftbot msftbot bot locked as resolved and limited conversation to collaborators Dec 18, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

3 participants