Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Default interfaces] Debugger support #9556

Closed
2 tasks
MichalStrehovsky opened this issue Jan 15, 2018 · 5 comments
Closed
2 tasks

[Default interfaces] Debugger support #9556

MichalStrehovsky opened this issue Jan 15, 2018 · 5 comments
Labels
area-Diagnostics-coreclr test-enhancement
Milestone

Comments

@MichalStrehovsky
Copy link
Member

MichalStrehovsky commented Jan 15, 2018

This tracks checking whether we need any work on the debugger side to be able to invoke default interface methods and if any work is needed, this will track the work in question.

At minimum, we'll need:

  • Support for invoking shared instance methods on generic interfaces. Those are kind of special.
  • Stepping into/over interface calls that hit the diamond inheritance problem. (These throw exception in an unexpected place.)
@lt72
Copy link
Contributor

lt72 commented Jan 15, 2018

@noahfalk @mikem8361 FYI

@noahfalk
Copy link
Member

noahfalk commented Jan 18, 2019

To the list above I suggest adding:

  • ENC tracked here: https://github.com/dotnet/coreclr/issues/16023
  • VS debugger support in the IL interpreter (adding @plnelson)
  • Manual testing of the VS debugger when using default interfaces
  • Update our automated debugger tests with at least one successful default interface case and one diamond pattern ambiguous default interface case. The test should cover stepping, func-eval, breakpoint inside the default implementation, and viewing the callstack. We should be able to get someone on @tommcdon's team to help when you are ready.

Looking into the stepping issue I think you were accurate in predicting trouble at that spot. I filed dotnet/coreclr#22059 with my best guess on what in the code needs to be fixed.

@sergiy-k
Copy link
Contributor

sergiy-k commented Mar 19, 2019

@tommcdon, could you please route this issue? Should be assigned to someone on your team?

@noahfalk
Copy link
Member

noahfalk commented Mar 19, 2019

Historically teams that build new runtime features own the testing of those features across all the perpendiculars. I think its reasonable for the diagnostics team to assist with adding a new regression test, running it for you in the future + the general consulting/assistance we already did, but not to own this work item all up.

@msftgits msftgits transferred this issue from dotnet/coreclr Jan 31, 2020
@msftgits msftgits added this to the Future milestone Jan 31, 2020
@tommcdon tommcdon modified the milestones: Future, 6.0.0 Jul 28, 2020
@tommcdon
Copy link
Member

tommcdon commented Oct 13, 2020

Closing as the work to support default interfaces is done to the best of our knowledge

@msftbot msftbot bot locked as resolved and limited conversation to collaborators Dec 18, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area-Diagnostics-coreclr test-enhancement
Projects
None yet
Development

No branches or pull requests

6 participants