Add configuration variables. #109907
Merged
Add configuration variables. #109907
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dotnet-policy-service
bot
added
the
community-contribution
|
Tagging subscribers to this area: @dotnet/gc |
mrsharm
reviewed
Nov 19, 2024
| @@ -157,9 +157,20 @@ public static int Main(string[] args) | |||
| string configFile = null; | |||
| bool okToContinue = true, doReplay = false; | |||
| string sTests = "tests", sSeed = "seed", exectime = "maximumExecutionTime"; | |||
| string output = ""; | |||
There was a problem hiding this comment.
Making use of StringBuilder here. https://learn.microsoft.com/en-us/dotnet/standard/base-types/stringbuilder
StringBuilder sb = new()
...
// To Add..
sb.AppendLine($"{kvp.Key}: {kvp.Value}");
...
// To Log..
rf._logger.WriteToInstrumentationLog(null, LoggingLevels.StartupShutdown, String.Format("Get GC Configuration Variables\n{0}",output.ToString()));
There was a problem hiding this comment.
or perhaps don't bother with output at all and just write the lines one at the time?
There was a problem hiding this comment.
@mrsharm I have updated the source with using StringBuilder.
Open
3 tasks
kasperk81
reviewed
Nov 20, 2024
Co-authored-by: kasperk81 <83082615+kasperk81@users.noreply.github.com>
mikelle-rogers
pushed a commit
to mikelle-rogers/runtime
that referenced
this pull request
Dec 10, 2024
* Add GC configuration to log * Add GC configuration to log * Code modification after review * Code modification after review * Update src/tests/GC/Stress/Framework/ReliabilityFramework.cs Co-authored-by: kasperk81 <83082615+kasperk81@users.noreply.github.com> --------- Co-authored-by: Mukund Raghav Sharma (Moko) <68247673+mrsharm@users.noreply.github.com> Co-authored-by: kasperk81 <83082615+kasperk81@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding the GC Configurations to logs at the start of the test by calling GC.GetConfigurationVariables().