Move ReflectionCoreCallbacks into ReflectionAugments #109912
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Leftover work identified in dotnet#109857.
jkotas
reviewed
Nov 18, 2024
| using Internal.Runtime; | ||
| using Internal.Runtime.Augments; | ||
|
|
||
| using EETypeElementType = Internal.Runtime.EETypeElementType; | ||
|
|
||
| namespace Internal.Reflection.Augments | ||
| { | ||
| public static class ReflectionAugments |
There was a problem hiding this comment.
Can this be internal and deleted from CompatibilitySuppressions.xml?
jkotas
reviewed
Nov 18, 2024
| get | ||
| { | ||
| // Reflection needs to work as the exception code calls GetType() and GetType().ToString() | ||
| return ReflectionAugments.IsInitialized; |
There was a problem hiding this comment.
Should this check whether s_executionEnvironment is initialized?
mikelle-rogers
pushed a commit
to mikelle-rogers/runtime
that referenced
this pull request
Dec 10, 2024
Leftover work identified in dotnet#109857.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Leftover work identified in #109857.
Cc @dotnet/ilc-contrib