[release/9.0-staging] TensorPrimitives XML docs: MinNumber/ReciprocalSqrt/ReciprocalSqrtEstimate oversights
#109922
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
They ware accidentally referring to maxima
The effective code was copied from the other reciprocal
|
Tagging subscribers to this area: @dotnet/area-system-numerics |
Open
3 tasks
|
cc: @jeffhandley |
stephentoub
approved these changes
Nov 19, 2024
tannergooding
approved these changes
Nov 19, 2024
jeffhandley
added
Servicing-approved
|
/ba-g Failures are known and unrelated |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of #109889 to release/9.0-staging
/cc @stephentoub @delreluca
Customer Impact
A customer found and fixed these API docs issues:
MinNumberrefers to maxima instead of minimaReciprocalSqrtandReciprocalSqrtEstimateare missing the square root in the explanation of the effective computationBecause XML doc comments are the source of truth for these APIs, updating the comments will result in the docs being corrected after the next servicing release.
Regression
Testing
n/a
Risk
Low. Docs / XML comments-only change.