Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Arm64-SVE: Fix up comments in optimizemaskconversions #109955

Merged
merged 3 commits into from
Nov 21, 2024

Conversation

a74nh
Copy link
Contributor

@a74nh a74nh commented Nov 19, 2024

Fixes up the review comments mentioned in #109286

@dotnet-issue-labeler dotnet-issue-labeler bot added the area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI label Nov 19, 2024
@dotnet-policy-service dotnet-policy-service bot added the community-contribution Indicates that the PR has been added by a community member label Nov 19, 2024
Copy link
Contributor

Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch
See info in area-owners.md if you want to be subscribed.

@a74nh a74nh marked this pull request as ready for review November 19, 2024 13:21
@a74nh
Copy link
Contributor Author

a74nh commented Nov 19, 2024

@kunalspathak

@a74nh a74nh added arch-arm64 arm-sve Work related to arm64 SVE/SVE2 support labels Nov 19, 2024
Copy link
Member

@kunalspathak kunalspathak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kunalspathak
Copy link
Member

Ignoring formatting failures - #109987 (comment)

@kunalspathak kunalspathak merged commit c31bb93 into dotnet:main Nov 21, 2024
107 of 108 checks passed
@a74nh a74nh deleted the mask2_github branch November 25, 2024 09:56
mikelle-rogers pushed a commit to mikelle-rogers/runtime that referenced this pull request Dec 10, 2024
Co-authored-by: Kunal Pathak <Kunal.Pathak@microsoft.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
arch-arm64 area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI arm-sve Work related to arm64 SVE/SVE2 support community-contribution Indicates that the PR has been added by a community member
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants