Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Fold "X relop 0" in assertprop" #110129

Merged
merged 2 commits into from
Nov 25, 2024

Conversation

jkotas
Copy link
Member

@jkotas jkotas commented Nov 25, 2024

Reverts #110076

Fixes #110127

@dotnet-issue-labeler dotnet-issue-labeler bot added the area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI label Nov 25, 2024
Copy link
Member

@EgorBo EgorBo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, I can confirm locally and see the problem. The bug is in optAssertionProp_RangeProperties so this PR just exposed it, will file a fix

@EgorBo
Copy link
Member

EgorBo commented Nov 25, 2024

/ba-g SPMI failures

@EgorBo EgorBo merged commit da9381e into main Nov 25, 2024
102 of 108 checks passed
EgorBo added a commit to EgorBo/runtime-1 that referenced this pull request Nov 25, 2024
mikelle-rogers pushed a commit to mikelle-rogers/runtime that referenced this pull request Dec 10, 2024
* Revert "Fold "X relop 0" in assertprop (dotnet#110076)"

This reverts commit b5bdce2.

* Dummy edit
mikelle-rogers pushed a commit to mikelle-rogers/runtime that referenced this pull request Dec 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Source generator tests failing with NullReferenceException in TaskReplicator
2 participants