Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow hiding UnmanagedCallersOnly exports #110152

Merged
merged 2 commits into from
Nov 26, 2024

Conversation

MichalStrehovsky
Copy link
Member

Should fix #109341. We currently rely on the linkerscript not exporting these, make it a per-assembly compiler switch. As a side effect it removes a piece of policy that skipped CoreLib exports from the exports linkerscript. The policy is now in .targets.

Cc @dotnet/ilc-contrib

Should fix dotnet#109341. We currently rely on the linkerscript not exporting these, now it's a per-assembly compiler switch.
Copy link
Member

@jkotas jkotas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

Co-authored-by: Jan Kotas <jkotas@microsoft.com>
@MichalStrehovsky MichalStrehovsky merged commit 354ec46 into dotnet:main Nov 26, 2024
88 checks passed
@MichalStrehovsky MichalStrehovsky deleted the fix109341 branch November 26, 2024 06:35
mikelle-rogers pushed a commit to mikelle-rogers/runtime that referenced this pull request Dec 10, 2024
Should fix dotnet#109341. We currently rely on the linkerscript not exporting these, now it's a per-assembly compiler switch.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Linking Native AOT for android complains about -fPIC
2 participants