[release/8.0-staging] Fix stubs for HybridGlobalization
#110183
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ilonatommy
added
arch-wasm
dotnet-policy-service
bot
added
the
linkable-framework
pavelsavara
approved these changes
Nov 26, 2024
javiercn
approved these changes
Nov 26, 2024
Open
3 tasks
1 task
maraf
approved these changes
Nov 27, 2024
ilonatommy
added
Servicing-approved
|
/ba-g coreclr failure on |
ilonatommy
merged commit 905ce13
into
dotnet:release/8.0-staging
173 of 183 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Partial backport of #93473 to release/8.0
Fixes #109951
Customer Impact
Customers that don’t use HybridGlobalization but use hashing methods from System.Globalization started having problems with publishing their apps. In publish we run trimming by default and this stub was activating HybridGlobalization way of processing for hashing, which means: throwing PNSE. In non-hybrid mode it’s not expected and it broke their publish pipe.
Regression
Regression from #85254.
Testing
Tested manually.
Risk
Medium, the change corrects a logical error / typo of stubbing a value with
truewhen its value isfalse.