Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JIT: Remove lexical dependencies in switch recognition #110253

Merged
merged 3 commits into from
Nov 29, 2024

Conversation

amanasifkhalid
Copy link
Member

@amanasifkhalid amanasifkhalid commented Nov 28, 2024

Fixes #107076. Part of #107749. Instead of relying on the "not equal" target of each test block being the next block, explicitly follow the chain of "not equal" targets.

@dotnet-issue-labeler dotnet-issue-labeler bot added the area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI label Nov 28, 2024
@amanasifkhalid
Copy link
Member Author

cc @dotnet/jit-contrib, @EgorBo PTAL. Small diffs. Thanks!

Copy link
Member

@EgorBo EgorBo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@amanasifkhalid
Copy link
Member Author

/ba-g timeout in win-x86 libraries tests

@amanasifkhalid amanasifkhalid changed the title JIT: Remove lexical dependences in switch recognition JIT: Remove lexical dependencies in switch recognition Nov 29, 2024
@amanasifkhalid amanasifkhalid merged commit 150d314 into dotnet:main Nov 29, 2024
105 of 108 checks passed
@amanasifkhalid amanasifkhalid deleted the switch-recognition branch November 29, 2024 16:04
eduardo-vp pushed a commit to eduardo-vp/runtime that referenced this pull request Dec 5, 2024
Fixes dotnet#107076. Part of dotnet#107749. Instead of relying on the "not equal" target of each test block being the next block, explicitly follow the chain of "not equal" targets.
mikelle-rogers pushed a commit to mikelle-rogers/runtime that referenced this pull request Dec 10, 2024
Fixes dotnet#107076. Part of dotnet#107749. Instead of relying on the "not equal" target of each test block being the next block, explicitly follow the chain of "not equal" targets.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Switch recognition should not be lexical
2 participants