[release/9.0-staging] Fix analyzer tracking of nullable enums #110331
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of #109430 to release/9.0-staging
/cc @sbomer
Customer Impact
Originally fixed in .NET 10 when found while investigating a related issue, and we got a customer report after the .NET 9 release. Customer reported via email when attempting to make an app NativeAOT and trim compatible. Impact is that there are unexpected analyzer warnings in source-generated code.
Simple example of a false positive warning customers could hit:
The actual customer-reported issue showed up in source-generated code not controlled by the customer, in a WinUI app:
for generated code like:
Regression
Testing
Added unit test which validates that the same pattern reported by the customer does not produces a warning.
Risk
Low. Analyzer-only change, doesn't impact runtime. Removes incorrect warnings produced by the trim analyzer.