Support generic fields in PersistedAssemblyBuilder #110372
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
There was a problem hiding this comment.
Copilot reviewed 2 out of 2 changed files in this pull request and generated no suggestions.
Comments skipped due to low confidence (1)
src/libraries/System.Reflection.Emit/tests/PersistedAssemblyBuilder/AssemblySaveTypeBuilderTests.cs:244
- The constructor call should use Type.EmptyTypes for clarity and to avoid potential issues with different runtime environments.
il.Emit(OpCodes.Newobj, declaringType.GetConstructor([]));
buyaa-n
reviewed
Dec 8, 2024
| [UnconditionalSuppressMessage("ReflectionAnalysis", "IL2075:UnrecognizedReflectionPattern", Justification = "Internal reflection implementation")] | ||
| static Type GetFieldType(FieldInfo fieldInfo) | ||
| { | ||
| if (fieldInfo.DeclaringType!.IsGenericType) |
There was a problem hiding this comment.
Suggested change
| if (fieldInfo.DeclaringType!.IsGenericType) | |
| if (fieldInfo.DeclaringType!.IsConstructedGenericType) |
jkotas
reviewed
Dec 10, 2024
| memberHandle = AddMemberReference(field.Name, GetTypeHandle(declaringType), | ||
| MetadataSignatureHelper.GetFieldSignature(field.FieldType, field.GetRequiredCustomModifiers(), field.GetOptionalCustomModifiers(), this)); | ||
| MetadataSignatureHelper.GetFieldSignature(GetFieldType(field), field.GetRequiredCustomModifiers(), field.GetOptionalCustomModifiers(), this)); |
There was a problem hiding this comment.
Can this use GetOriginalMemberIfConstructedType like the method cases? GetOriginalMemberIfConstructedType seems to be doing the same thing as the newly added method.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #110247
cc @jgh07
We will likely port to v9.x once verified in v10 since this was new functionality in v9.