Handle not truncating root folder in CorUnix::InternalCanonicalizeRealPath for all architectures instead of only amd64
#110425
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…lPath for all architectures instead of only amd64
This was referenced Dec 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We had this handling (of not truncating if the path is right in the root folder
/) ifdef-ed underHOST_AMD64for some reason. As a result, on other architectures we determine that the path doesn't exist and fail to load any assemblies from the root. This change simply removes the ifdef such that we have this handling on all architectures.Fixes #109593. Manually validated in a linux arm64 container.