Report bad code when localloc is in a funclet #121113
Merged
+5
−11
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The interpreter didn't check that localloc is not valid in funclets. Couple of coreclr tests were failing due to that. To make this work properly, I've removed marking blocks with BBClauseTry as it was not used for anything and preventing the check for code being in funclet working properly.
There was a problem hiding this comment.
Pull Request Overview
This PR adds validation to prevent localloc instructions inside funclets (exception handlers) in the interpreter, which is not supported. The change fixes failing CoreCLR tests by properly detecting when code is executing within a funclet context.
Key Changes:
- Removed unused
BBClauseTryenum value that was preventing proper funclet detection - Added validation check to reject
locallocinstructions inside funclets with appropriate error message
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| src/coreclr/interpreter/compiler.h | Removes unused BBClauseTry enum value from InterpBBClauseType |
| src/coreclr/interpreter/compiler.cpp | Removes code that marked try blocks and adds validation to reject localloc in funclets |
|
Tagging subscribers to this area: @BrzVlad, @janvorli, @kg |
kg
approved these changes
Oct 27, 2025
Open
3 tasks
|
/ba-g the windows arm64 infra is down and there change is doesn't have anything arm64 specific. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The interpreter didn't check that localloc is not valid in funclets. Couple of coreclr tests were failing due to that.
To make this work properly, I've removed marking blocks with BBClauseTry as it was not used for anything and preventing the check for code being in funclet working properly.