[Android] Add ActiveIssue to TimeZoneInfoTests.TestGetSystemTimeZones #122015
+1
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Tagging subscribers to this area: @dotnet/area-system-datetime |
Copilot finished reviewing on behalf of
simonrozsival
November 27, 2025 09:26
Contributor
There was a problem hiding this comment.
Pull request overview
This PR marks the TestGetSystemTimeZones test as having an active issue on Android by adding an ActiveIssue attribute. The test is failing on Android due to a known issue (#90269) where timezones with duplicate display names are returned, which has now manifested on more recent Android API levels, likely due to updated timezone data.
Key Changes
- Added
[ActiveIssue("https://github.com/dotnet/runtime/issues/90269", TestPlatforms.Android)]attribute to skip the test on Android until the underlying issue is resolved
matouskozak
approved these changes
Nov 27, 2025
simonrozsival
deleted the
dev/srozsival/disable-android-timezoneinfo-testgetsystemtimezones
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The TimeZoneInfoTests.TestGetSystemTimeZones is failing due to a known issue where on Android we return timezones with duplicate display names (#90269), now we're just seeing it on a more recent Android API levels. This is possibly due to an update to the TZ data.
Closes #121963
/cc @tarekgh @davidnguyen-tech