From 2545eaf8ddb4d55ad3b3544b857f2873d56d2387 Mon Sep 17 00:00:00 2001 From: Sven Boemer Date: Tue, 14 Apr 2026 16:31:44 -0700 Subject: [PATCH 1/2] Checkpoint from Copilot CLI for coding agent session --- .../tools/ILTrim.Tests/ILTrimExpectedFailures.txt | 12 ++++++++++++ 1 file changed, 12 insertions(+) diff --git a/src/coreclr/tools/ILTrim.Tests/ILTrimExpectedFailures.txt b/src/coreclr/tools/ILTrim.Tests/ILTrimExpectedFailures.txt index bd270eb6d9822a..622773161d6544 100644 --- a/src/coreclr/tools/ILTrim.Tests/ILTrimExpectedFailures.txt +++ b/src/coreclr/tools/ILTrim.Tests/ILTrimExpectedFailures.txt @@ -66,6 +66,8 @@ Attributes.OnlyKeepUsed.UnusedAttributeTypeOnTypeIsRemoved Attributes.OnlyKeepUsed.UnusedDerivedAttributeType Attributes.OnlyKeepUsed.UsedAttributeTypeOnEventIsKept Attributes.OnlyKeepUsed.UsedAttributeTypeOnParameterIsKept +Attributes.OnlyKeepUsed.UnusedAttributeOnGenericParameterIsRemoved +Attributes.OnlyKeepUsed.UnusedAttributeOnReturnTypeIsRemoved Attributes.OnlyKeepUsed.UsedAttributeTypeOnPropertyIsKept Attributes.SecurityAttributesOnUsedMethodAreKept Attributes.SecurityAttributesOnUsedTypeAreKept @@ -140,6 +142,7 @@ DataFlow.RuntimeAsyncMethods DataFlow.StaticInterfaceMethodDataflow DataFlow.SuppressWarningWithLinkAttributes DataFlow.UnresolvedMembers +DataFlow.TypeInfoIntrinsics DataFlow.VirtualMethodHierarchyDataflowAnnotationValidation DataFlow.XmlAnnotations DynamicDependencies.DynamicDependencyField @@ -207,6 +210,7 @@ Inheritance.Complex.NoKeptCtor.OverrideOfAbstractAndInterfaceMethodWhenInterface Inheritance.Interfaces.CanDisableUnusedInterfaces Inheritance.Interfaces.DefaultInterfaceMethods.DimProvidedByRecursiveInterface Inheritance.Interfaces.DefaultInterfaceMethods.MostSpecificDefaultImplementationKeptInstance +Inheritance.Interfaces.DefaultInterfaceMethods.InterfaceWithAttributeOnImplementation Inheritance.Interfaces.DefaultInterfaceMethods.MostSpecificDefaultImplementationKeptStatic Inheritance.Interfaces.DefaultInterfaceMethods.MultipleDimsProvidedByRecursiveInterface Inheritance.Interfaces.DefaultInterfaceMethods.StaticDefaultInterfaceMethodOnStruct @@ -214,6 +218,7 @@ Inheritance.Interfaces.DefaultInterfaceMethods.StaticDimProvidedByUnreferencedIf Inheritance.Interfaces.InterfaceImplementedThroughBaseInterface Inheritance.Interfaces.InterfaceOnUninstantiatedTypeRemoved Inheritance.Interfaces.InterfaceVariants +Inheritance.Interfaces.InterfaceWithoutNewSlot Inheritance.Interfaces.OnReferenceType.BaseProvidesInterfaceMember.GenericInterfaceWithEvent Inheritance.Interfaces.OnReferenceType.BaseProvidesInterfaceMember.GenericInterfaceWithMethodOnNoInstanceCtor Inheritance.Interfaces.OnReferenceType.BaseProvidesInterfaceMember.GenericInterfaceWithMethodOnNoInstanceCtor2 @@ -505,6 +510,9 @@ Symbols.ReferenceWithPortablePdbAndSymbolLinkingEnabledAndDeterministicMvid Symbols.ReferenceWithPortablePdbAndSymbolLinkingEnabledAndNewMvid Symbols.ReferenceWithPortablePdbCopyAction Symbols.ReferenceWithPortablePdbCopyActionAndSymbolLinkingEnabled +TestFramework.CanCompileILAssembly +TestFramework.ILVerificationErrorsCanBeIgnored +TestFramework.ILVerificationWorks TestFramework.VerifyAttributesInAssemblyWorks TestFramework.VerifyAttributesInAssemblyWorksWithStrings TestFramework.VerifyKeptAttributeAttributeWorks @@ -515,12 +523,14 @@ TypeForwarding.AttributeArgumentForwarded TypeForwarding.AttributeArgumentForwardedWithCopyAction TypeForwarding.AttributeEnumArgumentForwardedCopyUsedWithSweptForwarder TypeForwarding.AttributesScopeUpdated +TypeForwarding.MissingTargetReference TypeForwarding.MultiForwardedTypesWithCopyUsed TypeForwarding.MultiForwardedTypesWithLink TypeForwarding.NestedTypeForwarder TypeForwarding.SecurityAttributeScope TypeForwarding.TypeForwardedIsUpdatedForMissingType TypeForwarding.TypeForwarderOnlyAssemblyCanBePreservedViaLinkXml +TypeForwarding.TypeForwardersModifiers TypeForwarding.TypeForwardersRewrite TypeForwarding.UnusedForwarderWithAssemblyCopyIsKept TypeForwarding.UnusedForwarderWithAssemblyLinkedAndFacadeCopy @@ -549,6 +559,7 @@ UnreachableBlock.CompilerGeneratedCodeSubstitutions UnreachableBlock.ComplexConditions UnreachableBlock.ComplexConditionsOptimized UnreachableBlock.DeadVariables +UnreachableBlock.EndScopeOnMethoEnd UnreachableBlock.InstanceMethodSubstitutions UnreachableBlock.MethodArgumentPropagation UnreachableBlock.MethodWithParametersSubstitutions @@ -594,6 +605,7 @@ Warnings.CanDisableWarnAsError Warnings.CanDisableWarnings Warnings.CanNotSingleWarnPerAssembly Warnings.CanNotWarnAsErrorForDisabledVersion +Warnings.MultipleMethodsUseSameAsyncStateMachine Warnings.CanWarnAsError Warnings.CanWarnAsErrorGlobal Warnings.WarningSuppression.AddSuppressionsBeforeAttributeRemoval From 75e4dbcdf778060d7f1697b8ddce82e75b1d9b1f Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Michal=20Strehovsk=C3=BD?= Date: Tue, 14 Apr 2026 19:06:55 -0700 Subject: [PATCH 2/2] Clean up ILTrimExpectedFailures.txt Removed several unused attributes and warnings from expected failures list. --- .../tools/ILTrim.Tests/ILTrimExpectedFailures.txt | 13 +------------ 1 file changed, 1 insertion(+), 12 deletions(-) diff --git a/src/coreclr/tools/ILTrim.Tests/ILTrimExpectedFailures.txt b/src/coreclr/tools/ILTrim.Tests/ILTrimExpectedFailures.txt index 622773161d6544..90c596ee59fa81 100644 --- a/src/coreclr/tools/ILTrim.Tests/ILTrimExpectedFailures.txt +++ b/src/coreclr/tools/ILTrim.Tests/ILTrimExpectedFailures.txt @@ -66,8 +66,6 @@ Attributes.OnlyKeepUsed.UnusedAttributeTypeOnTypeIsRemoved Attributes.OnlyKeepUsed.UnusedDerivedAttributeType Attributes.OnlyKeepUsed.UsedAttributeTypeOnEventIsKept Attributes.OnlyKeepUsed.UsedAttributeTypeOnParameterIsKept -Attributes.OnlyKeepUsed.UnusedAttributeOnGenericParameterIsRemoved -Attributes.OnlyKeepUsed.UnusedAttributeOnReturnTypeIsRemoved Attributes.OnlyKeepUsed.UsedAttributeTypeOnPropertyIsKept Attributes.SecurityAttributesOnUsedMethodAreKept Attributes.SecurityAttributesOnUsedTypeAreKept @@ -142,7 +140,6 @@ DataFlow.RuntimeAsyncMethods DataFlow.StaticInterfaceMethodDataflow DataFlow.SuppressWarningWithLinkAttributes DataFlow.UnresolvedMembers -DataFlow.TypeInfoIntrinsics DataFlow.VirtualMethodHierarchyDataflowAnnotationValidation DataFlow.XmlAnnotations DynamicDependencies.DynamicDependencyField @@ -176,6 +173,7 @@ FeatureSettings.FeatureSubstitutions FeatureSettings.FeatureSubstitutionsInvalid FeatureSettings.FeatureSubstitutionsNested Generics.ArrayVariantCasting +Generics.GenericConstraints Generics.InstantiatedGenericEquality Generics.MdArrayVariantCasting Generics.MethodWithParameterWhichHasGenericParametersAndOverrideUsesADifferentNameForGenericParameter @@ -210,7 +208,6 @@ Inheritance.Complex.NoKeptCtor.OverrideOfAbstractAndInterfaceMethodWhenInterface Inheritance.Interfaces.CanDisableUnusedInterfaces Inheritance.Interfaces.DefaultInterfaceMethods.DimProvidedByRecursiveInterface Inheritance.Interfaces.DefaultInterfaceMethods.MostSpecificDefaultImplementationKeptInstance -Inheritance.Interfaces.DefaultInterfaceMethods.InterfaceWithAttributeOnImplementation Inheritance.Interfaces.DefaultInterfaceMethods.MostSpecificDefaultImplementationKeptStatic Inheritance.Interfaces.DefaultInterfaceMethods.MultipleDimsProvidedByRecursiveInterface Inheritance.Interfaces.DefaultInterfaceMethods.StaticDefaultInterfaceMethodOnStruct @@ -218,7 +215,6 @@ Inheritance.Interfaces.DefaultInterfaceMethods.StaticDimProvidedByUnreferencedIf Inheritance.Interfaces.InterfaceImplementedThroughBaseInterface Inheritance.Interfaces.InterfaceOnUninstantiatedTypeRemoved Inheritance.Interfaces.InterfaceVariants -Inheritance.Interfaces.InterfaceWithoutNewSlot Inheritance.Interfaces.OnReferenceType.BaseProvidesInterfaceMember.GenericInterfaceWithEvent Inheritance.Interfaces.OnReferenceType.BaseProvidesInterfaceMember.GenericInterfaceWithMethodOnNoInstanceCtor Inheritance.Interfaces.OnReferenceType.BaseProvidesInterfaceMember.GenericInterfaceWithMethodOnNoInstanceCtor2 @@ -510,9 +506,6 @@ Symbols.ReferenceWithPortablePdbAndSymbolLinkingEnabledAndDeterministicMvid Symbols.ReferenceWithPortablePdbAndSymbolLinkingEnabledAndNewMvid Symbols.ReferenceWithPortablePdbCopyAction Symbols.ReferenceWithPortablePdbCopyActionAndSymbolLinkingEnabled -TestFramework.CanCompileILAssembly -TestFramework.ILVerificationErrorsCanBeIgnored -TestFramework.ILVerificationWorks TestFramework.VerifyAttributesInAssemblyWorks TestFramework.VerifyAttributesInAssemblyWorksWithStrings TestFramework.VerifyKeptAttributeAttributeWorks @@ -523,14 +516,12 @@ TypeForwarding.AttributeArgumentForwarded TypeForwarding.AttributeArgumentForwardedWithCopyAction TypeForwarding.AttributeEnumArgumentForwardedCopyUsedWithSweptForwarder TypeForwarding.AttributesScopeUpdated -TypeForwarding.MissingTargetReference TypeForwarding.MultiForwardedTypesWithCopyUsed TypeForwarding.MultiForwardedTypesWithLink TypeForwarding.NestedTypeForwarder TypeForwarding.SecurityAttributeScope TypeForwarding.TypeForwardedIsUpdatedForMissingType TypeForwarding.TypeForwarderOnlyAssemblyCanBePreservedViaLinkXml -TypeForwarding.TypeForwardersModifiers TypeForwarding.TypeForwardersRewrite TypeForwarding.UnusedForwarderWithAssemblyCopyIsKept TypeForwarding.UnusedForwarderWithAssemblyLinkedAndFacadeCopy @@ -559,7 +550,6 @@ UnreachableBlock.CompilerGeneratedCodeSubstitutions UnreachableBlock.ComplexConditions UnreachableBlock.ComplexConditionsOptimized UnreachableBlock.DeadVariables -UnreachableBlock.EndScopeOnMethoEnd UnreachableBlock.InstanceMethodSubstitutions UnreachableBlock.MethodArgumentPropagation UnreachableBlock.MethodWithParametersSubstitutions @@ -605,7 +595,6 @@ Warnings.CanDisableWarnAsError Warnings.CanDisableWarnings Warnings.CanNotSingleWarnPerAssembly Warnings.CanNotWarnAsErrorForDisabledVersion -Warnings.MultipleMethodsUseSameAsyncStateMachine Warnings.CanWarnAsError Warnings.CanWarnAsErrorGlobal Warnings.WarningSuppression.AddSuppressionsBeforeAttributeRemoval