[cDAC] fix bug in DacDbi GetTypeHandle#127968
Merged
Merged
Conversation
Contributor
|
Tagging subscribers to this area: @steveisok, @tommcdon, @dotnet/dotnet-diag |
max-charlamb
approved these changes
May 8, 2026
hoyosjs
approved these changes
May 8, 2026
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the legacy cDAC DBI implementation of GetTypeHandle to return an error HRESULT when a TypeDef/TypeRef lookup does not resolve to a loaded type, aligning the managed implementation with the native DAC behavior (returning CORDBG_E_CLASS_NOT_LOADED instead of reporting success with a null/zero handle).
Changes:
- Treat
TypeDefToMethodTable/TypeRefToMethodTablelookup misses as failures by returningCORDBG_E_CLASS_NOT_LOADED. - Ensure the method doesn’t silently succeed when
*pRetValends up as0.
Show a summary per file
| File | Description |
|---|---|
| src/native/managed/cdac/Microsoft.Diagnostics.DataContractReader.Legacy/Dbi/DacDbiImpl.cs | Make GetTypeHandle return CORDBG_E_CLASS_NOT_LOADED when the resolved type handle is zero (not found / not loaded). |
Copilot's findings
- Files reviewed: 1/1 changed files
- Comments generated: 1
jakobbotsch
pushed a commit
to jakobbotsch/runtime
that referenced
this pull request
May 12, 2026
Return exception HResult when type not found
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Return exception HResult when type not found