Skip to content

Restore E_NOTIMPL fallback in DacDbiInterfaceImpl::GetContext #128499

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
tommcdon merged 1 commit into from
May 23, 2026
+49 −2
Merged

Restore E_NOTIMPL fallback in DacDbiInterfaceImpl::GetContext #128499

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
51 changes: 49 additions & 2 deletions src/coreclr/debug/daccess/dacdbiimpl.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5679,10 +5679,57 @@ HRESULT STDMETHODCALLTYPE DacDbiInterfaceImpl::GetContext(VMPTR_Thread vmThread,
{
// If the filter context is NULL, then we use the true context of the thread.
pContextBuffer->ContextFlags = DT_CONTEXT_ALL;
IfFailThrow(m_pTarget->GetThreadContext(pThread->GetOSThreadId(),
HRESULT hrContext = m_pTarget->GetThreadContext(pThread->GetOSThreadId(),
pContextBuffer->ContextFlags,
sizeof(DT_CONTEXT),
reinterpret_cast<BYTE *>(pContextBuffer)));
reinterpret_cast<BYTE *>(pContextBuffer));
if (hrContext == E_NOTIMPL)
{
// GetThreadContext is not implemented on this data target (e.g. Linux).
// That's why we have to make do with context we can obtain from Frames explicitly stored in Thread object.
// It suffices for managed debugging stackwalk.
REGDISPLAY tmpRd = {};
T_CONTEXT tmpContext = {};
FillRegDisplay(&tmpRd, &tmpContext);

// Going through thread Frames and looking for first (deepest one) one that
// that has context available for stackwalking (SP and PC)
// For example: RedirectedThreadFrame, InlinedCallFrame, DynamicHelperFrame
Comment thread
tommcdon marked this conversation as resolved.
Frame *frame = pThread->GetFrame();

while (frame != NULL && frame != FRAME_TOP)
{
#ifdef FEATURE_INTERPRETER
if (frame->GetFrameIdentifier() == FrameIdentifier::InterpreterFrame)
{
PTR_InterpreterFrame pInterpreterFrame = dac_cast<PTR_InterpreterFrame>(frame);
pInterpreterFrame->SetContextToInterpMethodContextFrame(&tmpContext);
CopyMemory(pContextBuffer, &tmpContext, sizeof(*pContextBuffer));
return S_OK;
}
Comment thread
tommcdon marked this conversation as resolved.
#endif // FEATURE_INTERPRETER
frame->UpdateRegDisplay(&tmpRd);
if (GetRegdisplaySP(&tmpRd) != 0 && GetControlPC(&tmpRd) != 0)
{
UpdateContextFromRegDisp(&tmpRd, &tmpContext);
CopyMemory(pContextBuffer, &tmpContext, sizeof(*pContextBuffer));
pContextBuffer->ContextFlags = DT_CONTEXT_CONTROL
#if defined(TARGET_AMD64) || defined(TARGET_ARM)
| DT_CONTEXT_INTEGER
#endif
;
return S_OK;
}
frame = frame->Next();
}

// It looks like this thread is not running managed code.
ZeroMemory(pContextBuffer, sizeof(*pContextBuffer));
}
else
{
IfFailThrow(hrContext);
}
}
else
{
Expand Down
Loading