Skip to content

Restore missing consolidated nullable jit64 test projects#129138

Draft
Copilot wants to merge 3 commits into
mainfrom
copilot/fix-jit64-nullable-valuetype-tests
Draft

Restore missing consolidated nullable jit64 test projects#129138
Copilot wants to merge 3 commits into
mainfrom
copilot/fix-jit64-nullable-valuetype-tests

Conversation

Copilot AI commented Jun 8, 2026

Copy link
Copy Markdown
Contributor

PR #120992 converted nullable jit64 tests for consolidation but missed the consolidating project files for box-unbox and castclass, leaving 343 tests unbuilt and unexecuted. This change restores project ownership for those test trees by adding explicit aggregate .csproj files.

  • What changed

    • Added /home/runner/work/runtime/runtime/src/tests/JIT/jit64/valuetypes/nullable/box-unbox/box-unbox.csproj
    • Added /home/runner/work/runtime/runtime/src/tests/JIT/jit64/valuetypes/nullable/castclass/castclass.csproj
  • Project contents

    • box-unbox.csproj: includes all 193 subtree test sources
    • castclass.csproj: includes all 150 subtree test sources
    • Both projects also include shared /home/runner/work/runtime/runtime/src/tests/JIT/jit64/valuetypes/nullable/structdef.cs
    • Both reference $(TestLibraryProjectPath)
  • Resulting behavior

    • The previously orphaned nullable jit64 tests are back under buildable test projects and can flow through normal test build/execution paths again.
<ItemGroup>
  <Compile Include="../structdef.cs" />
  <Compile Include="castclass/castclass001.cs" />
  <!-- ... -->
</ItemGroup>
<ItemGroup>
  <ProjectReference Include="$(TestLibraryProjectPath)" />
</ItemGroup>

Co-authored-by: JulieLeeMSFT <63486087+JulieLeeMSFT@users.noreply.github.com>
Copilot AI requested review from Copilot and removed request for Copilot June 8, 2026 21:19
Co-authored-by: JulieLeeMSFT <63486087+JulieLeeMSFT@users.noreply.github.com>
Copilot AI requested review from Copilot and removed request for Copilot June 8, 2026 21:20
Copilot AI changed the title [WIP] Fix jit64 nullable valuetype tests disabled by missing csproj Restore missing consolidated nullable jit64 test projects Jun 8, 2026
Copilot AI requested a review from JulieLeeMSFT June 8, 2026 21:21
@github-actions github-actions Bot added the area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI label Jun 8, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI

Projects

None yet

Development

Successfully merging this pull request may close these issues.

JIT/jit64 nullable valuetype tests (343) silently disabled by PR #120992 — no consolidating csproj

2 participants