From ccc25b436bdfdea689a4654bd4708b1d52b194bc Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Alexander=20K=C3=B6plinger?= Date: Tue, 14 Jul 2026 19:20:43 +0200 Subject: [PATCH] Remove unnecessary DisablePackageBaselineValidation from projects - System.Linq.AsyncEnumerable already shipped a stable version - Microsoft.NET.Runtime.WebAssembly.Templates can't be validated - Mono.Linker doesn't actually ship and we already set DisablePackageBaselineValidation in that case in eng/packaging.targets --- docs/coding-guidelines/project-guidelines.md | 2 +- .../src/System.Linq.AsyncEnumerable.csproj | 5 ----- .../Microsoft.NET.Runtime.WebAssembly.Templates.csproj | 1 + src/tools/illink/src/linker/Mono.Linker.csproj | 4 ---- 4 files changed, 2 insertions(+), 10 deletions(-) diff --git a/docs/coding-guidelines/project-guidelines.md b/docs/coding-guidelines/project-guidelines.md index ca72ec4e2c1ce4..5ec42d75c9c0d0 100644 --- a/docs/coding-guidelines/project-guidelines.md +++ b/docs/coding-guidelines/project-guidelines.md @@ -78,7 +78,7 @@ By default, packable project (mostly source projects) have APICompat package val This also includes _package baseline validation_ which automatically restores a previously produced package version (from the NuGet feeds) of the project and compares the public API to guard against breaking changes. When adding a brand new library, package baseline validation needs to be disabled temporarily as there's no previously produced package available yet. This should be done -by setting the `DisablePackageBaselineValidation` property to true: https://github.com/dotnet/runtime/blob/634641c806b129bd6892e071aece3f4916ea519d/src/libraries/System.Linq.AsyncEnumerable/src/System.Linq.AsyncEnumerable.csproj#L14-L17 +by setting the `DisablePackageBaselineValidation` property to true. ## TargetFramework conditions `TargetFramework` conditions should be avoided in the first PropertyGroup as that causes DesignTimeBuild issues: https://github.com/dotnet/project-system/issues/6143 diff --git a/src/libraries/System.Linq.AsyncEnumerable/src/System.Linq.AsyncEnumerable.csproj b/src/libraries/System.Linq.AsyncEnumerable/src/System.Linq.AsyncEnumerable.csproj index ae4bfff4e77486..527d335cab0d04 100644 --- a/src/libraries/System.Linq.AsyncEnumerable/src/System.Linq.AsyncEnumerable.csproj +++ b/src/libraries/System.Linq.AsyncEnumerable/src/System.Linq.AsyncEnumerable.csproj @@ -10,11 +10,6 @@ $(NoWarn);CA2007 - - - true diff --git a/src/mono/wasm/templates/Microsoft.NET.Runtime.WebAssembly.Templates.csproj b/src/mono/wasm/templates/Microsoft.NET.Runtime.WebAssembly.Templates.csproj index b1bae872a5ba21..a8c71049ab53ff 100644 --- a/src/mono/wasm/templates/Microsoft.NET.Runtime.WebAssembly.Templates.csproj +++ b/src/mono/wasm/templates/Microsoft.NET.Runtime.WebAssembly.Templates.csproj @@ -17,6 +17,7 @@ $(NoWarn);NU5128 true false + true false diff --git a/src/tools/illink/src/linker/Mono.Linker.csproj b/src/tools/illink/src/linker/Mono.Linker.csproj index 515e16d474d9b2..35a824496ab379 100644 --- a/src/tools/illink/src/linker/Mono.Linker.csproj +++ b/src/tools/illink/src/linker/Mono.Linker.csproj @@ -9,10 +9,6 @@ true false Microsoft.NET.ILLink - - true false $(NoWarn);CS8524