Ignore the executable file be deleted in Process Start

[lindexi]

In MAC System when using Process.Start method to start a excetuable file it can still delete this file and the Interop.libproc.proc_pidpath method still execute and return a win32 exception

[lindexi]

See: dotnet-campus/dotnetCampus.UpdateAllDotNetTools#4

[ghost]

Tagging subscribers to this area: @eiriktsarpalis
See info in area-owners.md if you want to be subscribed.

[adamsitnik]

Hi @lindexi

I am not sure if I understand the problem that you are trying to solve. Could you please provide a sample repro and full explanation of what you are trying to achieve and how this PR helps you?

Thank,
Adam

[lindexi]

@adamsitnik This is the problem: dotnet-campus/dotnetCampus.UpdateAllDotNetTools#4

[lindexi]

@adamsitnik And I write a blog (Chinese) about it. This is the google translate link: https://translate.google.cn/translate?sl=en&tl=zh-CN&u=https%3A%2F%2Fblog.lindexi.com%2Fpost%2Fdotnet-core-%25E5%259C%25A8-MAC-%25E7%25B3%25BB%25E7%25BB%259F%25E4%25B8%258B%25E5%2588%25A0%25E9%2599%25A4%25E5%25BA%2594%25E7%2594%25A8%25E7%25A8%258B%25E5%25BA%258F%25E8%2587%25AA%25E5%25B7%25B1%25E5%2590%258E%25E8%25B0%2583-Process-Start-%25E6%2596%25B9%25E6%25B3%2595%25E5%25B0%2586%25E4%25BC%259A%25E6%258A%259B%25E5%2587%25BA-Win32-%25E5%25BC%2582%25E5%25B8%25B8.html

[jkotas]

I think this fix is ok workaround.

It may be better to add a direct way to get current process executable path to System.Native. Going through libproc to find the current process executable path is unnecessary compilation.

Also, we ought to have a public API that returns the current process executable path. I have opened API proposal at: #40862

[jkotas]

Thanks!

[danmoseley]

Should it filter for NativeErrorCode == 2?

[lindexi]

@danmosemsft Thank you. I agree with you.

[jkotas]

I see this as a temporary workaround until we get the proper API that returns the executable path in place. I do not think it is that important to make this condition perfect, and it is likely that the proc_pidpath has other failure modes e.g. permission errors.

[danmoseley]

Sounds good