Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Span overloads to System.Numerics.Vectors #50062

Merged
merged 1 commit into from Mar 23, 2021
Merged

Conversation

C-xC-c
Copy link
Contributor

@C-xC-c C-xC-c commented Mar 22, 2021

Fixes #25608

@dotnet-issue-labeler
Copy link

Note regarding the new-api-needs-documentation label:

This serves as a reminder for when your PR is modifying a ref *.cs file and adding/modifying public APIs, to please make sure the API implementation in the src *.cs file is documented with triple slash comments, so the PR reviewers can sign off that change.

@msftbot
Copy link
Contributor

msftbot bot commented Mar 22, 2021

Tagging subscribers to this area: @tannergooding, @pgovind
See info in area-owners.md if you want to be subscribed.

Issue Details

Fixes #25608

Author: C-xC-c
Assignees: -
Labels:

area-System.Numerics, new-api-needs-documentation

Milestone: -

@GrabYourPitchforks
Copy link
Member

GrabYourPitchforks commented Mar 22, 2021

@tannergooding You've mentioned in the past that some SIMD instructions (specifically, instructions that access float* or double*) have some weirdness when it comes to alignment. Is using Read/WriteUnaligned in these code paths likely to have noticeable perf impact?

@tannergooding
Copy link
Member

Is using Read/WriteUnaligned in these code paths likely to have noticeable perf impact?

It shouldn't on modern CPUs. The only real impact should be if it crosses a cache line or page boundary and then only if you repeatedly do that in a hot loop.

@tannergooding
Copy link
Member

CC. @pgovind, can you give a quick review so we can merge?

Copy link
Contributor

@pgovind pgovind left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@tannergooding tannergooding merged commit dddac29 into dotnet:main Mar 23, 2021
@tannergooding
Copy link
Member

Thanks for the contribution!

@msftbot msftbot bot locked as resolved and limited conversation to collaborators Apr 22, 2021
@karelz karelz added this to the 6.0.0 milestone May 20, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

System.Numerics.Vectors and Span<T>
5 participants