[mono] Add HAVE_PTHREAD_JIT_WRITE_PROTECT_NP to cmake config.h.in#51610
Merged
Conversation
Otherwise mono_codeman_enable_write is a no-op Should fix jiting on Apple ARM64
This comment has been minimized.
This comment has been minimized.
Member
Author
|
To test, on an M1: $ arch -x86_64 ./build.sh mono+libs -c Debug --arch arm64
$ cd src/libraries/System.Buffers/tests
$ ../../../../dotnet.sh build /t:Test /p:TargetArchitecture=arm64 |
check_function_exists doesn't look at the headers, only at linking, so it can't detect functions marked unavailable in Apple headers.
Member
Author
|
So interestingly, this seems to mean that JITing on arm64 in MacCatalyst apps is not possible. The So this did not work: $ arch -x86_64 ./build.sh mono+libs -c Debug --arch arm64 --os maccatalyst
$ cd src/libraries/System.Buffers/tests
$ ../../../../dotnet.sh build /t:Test /p:TargetArchitecture=arm64 /p:TargetOS=maccatalystI'm still investigating the crash to see if there's something else going wrong. But at first blush it seems like the write protection bit still needs to be toggled, but the API for doing so is not available. |
vargaz
approved these changes
Apr 21, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Otherwise mono_codeman_enable_write is a no-op
Should fix jiting on macOS arm64
Fixes #49042