Implemented ReadAtLeastAsync #51979
Merged
Implemented ReadAtLeastAsync #51979
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Implemented the PipeReader implementation and override the method on Pipe. - The Pipe implementation has some caveats. Calling ReadAtLeast messes with the pipe back pressure since it's trying to prevent deadlocks. This means that if ReadAsync is called with a big threshold, the writer will write as fast as it can ignoring the PauseThreshold up until the reader is unblocked. In a sense, the call to ReadAtLeast async overrides the pause threshold for that one read. - Added tests - Added missing StreamConformance tests to the solution so it would build
|
Note regarding the This serves as a reminder for when your PR is modifying a ref *.cs file and adding/modifying public APIs, to please make sure the API implementation in the src *.cs file is documented with triple slash comments, so the PR reviewers can sign off that change. |
- Flip the reading state off when we decide not to accept the read
davidfowl
commented
Apr 28, 2021
src/libraries/System.IO.Pipelines/src/System/IO/Pipelines/Pipe.cs
Outdated
Show resolved
Hide resolved
halter73
reviewed
Apr 28, 2021
pakrym
reviewed
Apr 30, 2021
src/libraries/System.IO.Pipelines/src/System/IO/Pipelines/Pipe.cs
Outdated
Show resolved
Hide resolved
halter73
approved these changes
May 1, 2021
|
Looked at the failures and they are unrelated. |
This was referenced May 1, 2021
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #25063
PS: I need some more default implementation tests.Done