From 5a588d0f5fc7d2315771ce6f9a65273f1adeef7d Mon Sep 17 00:00:00 2001 From: "dotnet-maestro[bot]" <42748379+dotnet-maestro[bot]@users.noreply.github.com> Date: Tue, 22 Jun 2021 09:53:13 +0000 Subject: [PATCH 1/6] [main] Update dependencies from 9 repositories (#54218) [main] Update dependencies from 9 repositories - Merge branch 'main' into darc-main-b0a81754-f267-416d-a8e2-cf56f8c1ee3e - PInvoke warnings fixes for OOB assemblies - Update testPackages.proj - Update testPackages.proj - Update dependencies from https://github.com/dotnet/arcade build 20210621.1 - Merge branch 'main' into darc-main-b0a81754-f267-416d-a8e2-cf56f8c1ee3e Conflicts: eng/Version.Details.xml eng/Versions.props - Fix xml - Update dependencies from https://github.com/dotnet/xharness build 20210622.2 --- .config/dotnet-tools.json | 2 +- eng/Version.Details.xml | 203 +++++++++--------- eng/Versions.props | 88 ++++---- eng/common/generate-locproject.ps1 | 13 +- .../templates/job/source-index-stage1.yml | 4 + global.json | 10 +- .../src/ILLink/ILLink.Suppressions.xml | 2 +- .../src/ILLink/ILLink.Suppressions.xml | 20 +- .../src/ILLink/ILLink.Suppressions.xml | 2 +- .../src/ILLink/ILLink.Suppressions.xml | 2 +- .../src/ILLink/ILLink.Suppressions.xml | 26 +-- src/libraries/pkg/test/testPackages.proj | 2 +- 12 files changed, 198 insertions(+), 176 deletions(-) diff --git a/.config/dotnet-tools.json b/.config/dotnet-tools.json index 02e0543e98b8e..6428121a0fec7 100644 --- a/.config/dotnet-tools.json +++ b/.config/dotnet-tools.json @@ -15,7 +15,7 @@ ] }, "microsoft.dotnet.xharness.cli": { - "version": "1.0.0-prerelease.21314.1", + "version": "1.0.0-prerelease.21322.2", "commands": [ "xharness" ] diff --git a/eng/Version.Details.xml b/eng/Version.Details.xml index 4177e280edf32..e8995dca95d92 100644 --- a/eng/Version.Details.xml +++ b/eng/Version.Details.xml @@ -1,222 +1,221 @@ - + https://github.com/dotnet/icu - d7db669b70f4dd67ec001c192f9809c218cab88b + 59588c1257a842089d0b7df3bad1cdd69ac720e1 - + https://github.com/dotnet/arcade - 4a2b475948d498b89fedef7cf890883f49bc1ea3 - + 36b148348ee8312f6369c0c56b0d0fe07deec603 - + https://github.com/dotnet/arcade - 4a2b475948d498b89fedef7cf890883f49bc1ea3 + 36b148348ee8312f6369c0c56b0d0fe07deec603 - + https://github.com/dotnet/arcade - 4a2b475948d498b89fedef7cf890883f49bc1ea3 + 36b148348ee8312f6369c0c56b0d0fe07deec603 - + https://github.com/dotnet/arcade - 4a2b475948d498b89fedef7cf890883f49bc1ea3 + 36b148348ee8312f6369c0c56b0d0fe07deec603 - + https://github.com/dotnet/arcade - 4a2b475948d498b89fedef7cf890883f49bc1ea3 + 36b148348ee8312f6369c0c56b0d0fe07deec603 - + https://github.com/dotnet/arcade - 4a2b475948d498b89fedef7cf890883f49bc1ea3 + 36b148348ee8312f6369c0c56b0d0fe07deec603 - + https://github.com/dotnet/arcade - 4a2b475948d498b89fedef7cf890883f49bc1ea3 + 36b148348ee8312f6369c0c56b0d0fe07deec603 - + https://github.com/dotnet/arcade - 4a2b475948d498b89fedef7cf890883f49bc1ea3 + 36b148348ee8312f6369c0c56b0d0fe07deec603 - + https://github.com/dotnet/arcade - 4a2b475948d498b89fedef7cf890883f49bc1ea3 + 36b148348ee8312f6369c0c56b0d0fe07deec603 - + https://github.com/dotnet/arcade - 4a2b475948d498b89fedef7cf890883f49bc1ea3 + 36b148348ee8312f6369c0c56b0d0fe07deec603 - + https://github.com/dotnet/arcade - 4a2b475948d498b89fedef7cf890883f49bc1ea3 + 36b148348ee8312f6369c0c56b0d0fe07deec603 - + https://github.com/dotnet/arcade - 4a2b475948d498b89fedef7cf890883f49bc1ea3 + 36b148348ee8312f6369c0c56b0d0fe07deec603 - + https://github.com/dotnet/arcade - 4a2b475948d498b89fedef7cf890883f49bc1ea3 + 36b148348ee8312f6369c0c56b0d0fe07deec603 - + https://github.com/dotnet/arcade - 4a2b475948d498b89fedef7cf890883f49bc1ea3 + 36b148348ee8312f6369c0c56b0d0fe07deec603 - + https://github.com/dotnet/arcade - 4a2b475948d498b89fedef7cf890883f49bc1ea3 + 36b148348ee8312f6369c0c56b0d0fe07deec603 - + https://github.com/dotnet/arcade - 4a2b475948d498b89fedef7cf890883f49bc1ea3 + 36b148348ee8312f6369c0c56b0d0fe07deec603 https://github.com/microsoft/vstest 140434f7109d357d0158ade9e5164a4861513965 - + https://github.com/dotnet/runtime-assets - 0612b036e67746930105231b605c4df9ac6ed47e + 8d7b898b96cbdb868cac343e938173105287ed9e - + https://github.com/dotnet/runtime-assets - 0612b036e67746930105231b605c4df9ac6ed47e + 8d7b898b96cbdb868cac343e938173105287ed9e - + https://github.com/dotnet/runtime-assets - 0612b036e67746930105231b605c4df9ac6ed47e + 8d7b898b96cbdb868cac343e938173105287ed9e - + https://github.com/dotnet/runtime-assets - 0612b036e67746930105231b605c4df9ac6ed47e + 8d7b898b96cbdb868cac343e938173105287ed9e - + https://github.com/dotnet/runtime-assets - 0612b036e67746930105231b605c4df9ac6ed47e + 8d7b898b96cbdb868cac343e938173105287ed9e - + https://github.com/dotnet/runtime-assets - 0612b036e67746930105231b605c4df9ac6ed47e + 8d7b898b96cbdb868cac343e938173105287ed9e - + https://github.com/dotnet/runtime-assets - 0612b036e67746930105231b605c4df9ac6ed47e + 8d7b898b96cbdb868cac343e938173105287ed9e - + https://github.com/dotnet/runtime-assets - 0612b036e67746930105231b605c4df9ac6ed47e + 8d7b898b96cbdb868cac343e938173105287ed9e - + https://github.com/dotnet/runtime-assets - 0612b036e67746930105231b605c4df9ac6ed47e + 8d7b898b96cbdb868cac343e938173105287ed9e - + https://github.com/dotnet/llvm-project - a76e596b96a1b9b4bc7a213f9a8335bcd9189b67 + 4f0293e0a254a2f014643ecbe973b81f26c87fd4 - + https://github.com/dotnet/llvm-project - a76e596b96a1b9b4bc7a213f9a8335bcd9189b67 + 4f0293e0a254a2f014643ecbe973b81f26c87fd4 - + https://github.com/dotnet/llvm-project - a76e596b96a1b9b4bc7a213f9a8335bcd9189b67 + 4f0293e0a254a2f014643ecbe973b81f26c87fd4 - + https://github.com/dotnet/llvm-project - a76e596b96a1b9b4bc7a213f9a8335bcd9189b67 + 4f0293e0a254a2f014643ecbe973b81f26c87fd4 - + https://github.com/dotnet/llvm-project - a76e596b96a1b9b4bc7a213f9a8335bcd9189b67 + 4f0293e0a254a2f014643ecbe973b81f26c87fd4 - + https://github.com/dotnet/llvm-project - a76e596b96a1b9b4bc7a213f9a8335bcd9189b67 + 4f0293e0a254a2f014643ecbe973b81f26c87fd4 - + https://github.com/dotnet/llvm-project - a76e596b96a1b9b4bc7a213f9a8335bcd9189b67 + 4f0293e0a254a2f014643ecbe973b81f26c87fd4 - + https://github.com/dotnet/llvm-project - a76e596b96a1b9b4bc7a213f9a8335bcd9189b67 + 4f0293e0a254a2f014643ecbe973b81f26c87fd4 https://github.com/dotnet/runtime 38017c3935de95d0335bac04f4901ddfc2718656 - + https://github.com/dotnet/runtime - af5c238556e204583b129cc8f5c7338f84dc2c40 + f891033db5b8ebf651176a3dcc3bec74a217f85e - + https://github.com/dotnet/runtime - af5c238556e204583b129cc8f5c7338f84dc2c40 + f891033db5b8ebf651176a3dcc3bec74a217f85e - + https://github.com/dotnet/runtime - af5c238556e204583b129cc8f5c7338f84dc2c40 + f891033db5b8ebf651176a3dcc3bec74a217f85e - + https://github.com/dotnet/runtime - af5c238556e204583b129cc8f5c7338f84dc2c40 + f891033db5b8ebf651176a3dcc3bec74a217f85e - + https://github.com/dotnet/runtime - af5c238556e204583b129cc8f5c7338f84dc2c40 + f891033db5b8ebf651176a3dcc3bec74a217f85e - + https://github.com/dotnet/runtime - af5c238556e204583b129cc8f5c7338f84dc2c40 + f891033db5b8ebf651176a3dcc3bec74a217f85e - + https://github.com/dotnet/runtime - af5c238556e204583b129cc8f5c7338f84dc2c40 + f891033db5b8ebf651176a3dcc3bec74a217f85e - + https://github.com/mono/linker - caeaf2a3fb3f636805fdd4881df4f9a539fff8f6 + c739a81ba553b00df1cb2f5b9974deae996b757a - + https://github.com/dotnet/xharness - d6f8a4ad30908fb210390380eae97264e4fbe8ce + 0bb4a23b1b686e8fefde9d4c860b26a8fafc303e - + https://github.com/dotnet/xharness - d6f8a4ad30908fb210390380eae97264e4fbe8ce + 0bb4a23b1b686e8fefde9d4c860b26a8fafc303e - + https://github.com/dotnet/arcade - 85a65ea1fca1d0867f699fed44d191358270bf6a + 36b148348ee8312f6369c0c56b0d0fe07deec603 - + https://dev.azure.com/dnceng/internal/_git/dotnet-optimization - 4e5bea15eb5a9c8cf9142195b1c9c78437a5b27f + f291c7f87a563f29ff2a9af7378495769d97389c - + https://dev.azure.com/dnceng/internal/_git/dotnet-optimization - 4e5bea15eb5a9c8cf9142195b1c9c78437a5b27f + f291c7f87a563f29ff2a9af7378495769d97389c - + https://dev.azure.com/dnceng/internal/_git/dotnet-optimization - 4e5bea15eb5a9c8cf9142195b1c9c78437a5b27f + f291c7f87a563f29ff2a9af7378495769d97389c - + https://dev.azure.com/dnceng/internal/_git/dotnet-optimization - 4e5bea15eb5a9c8cf9142195b1c9c78437a5b27f + f291c7f87a563f29ff2a9af7378495769d97389c https://github.com/dotnet/emsdk defa37b05c734e025292c5747664e970cd2ac444 - + https://github.com/dotnet/hotreload-utils - 25b814e010cd4796cedfbcce72a274c26928f496 + 6adb8ac00a59fe409f232b8b32758aa7d10b4d1d - https://github.com/dotnet/runtime-assets + https://github.com/dotnet/runtime-assets 8d7b898b96cbdb868cac343e938173105287ed9e diff --git a/eng/Versions.props b/eng/Versions.props index b62b9b4854cfc..3bc9edaa1b14c 100644 --- a/eng/Versions.props +++ b/eng/Versions.props @@ -49,28 +49,28 @@ 3.10.0-2.final 3.10.0-2.final - 6.0.0-beta.21311.3 - 6.0.0-beta.21311.3 - 6.0.0-beta.21311.3 - 6.0.0-beta.21311.3 - 6.0.0-beta.21311.3 - 6.0.0-beta.21311.3 - 2.5.1-beta.21311.3 - 6.0.0-beta.21311.3 - 6.0.0-beta.21311.3 - 6.0.0-beta.21311.3 - 6.0.0-beta.21311.3 - 6.0.0-beta.21311.3 - 6.0.0-beta.21311.3 + 6.0.0-beta.21321.1 + 6.0.0-beta.21321.1 + 6.0.0-beta.21321.1 + 6.0.0-beta.21321.1 + 6.0.0-beta.21321.1 + 6.0.0-beta.21321.1 + 2.5.1-beta.21321.1 + 6.0.0-beta.21321.1 + 6.0.0-beta.21321.1 + 6.0.0-beta.21321.1 + 6.0.0-beta.21321.1 + 6.0.0-beta.21321.1 + 6.0.0-beta.21321.1 5.9.0-preview.2 6.0.0-alpha.1.20612.4 - 6.0.0-preview.6.21314.1 - 6.0.0-preview.6.21314.1 + 6.0.0-preview.7.21321.2 + 6.0.0-preview.7.21321.2 3.1.0 - 6.0.0-preview.6.21314.1 + 6.0.0-preview.7.21321.2 5.0.0 4.3.0 @@ -104,27 +104,27 @@ 5.0.0 5.0.0 4.8.1 - 6.0.0-preview.6.21314.1 - 6.0.0-preview.6.21314.1 + 6.0.0-preview.7.21321.2 + 6.0.0-preview.7.21321.2 4.5.4 4.5.0 - 6.0.0-preview.6.21314.1 + 6.0.0-preview.7.21321.2 6.0.0-beta.21314.1 6.0.0-beta.21307.1 - 6.0.0-beta.21307.1 - 6.0.0-beta.21307.1 - 6.0.0-beta.21307.1 - 6.0.0-beta.21307.1 - 6.0.0-beta.21307.1 - 6.0.0-beta.21307.1 - 6.0.0-beta.21307.1 - 6.0.0-beta.21307.1 + 6.0.0-beta.21314.1 + 6.0.0-beta.21314.1 + 6.0.0-beta.21314.1 + 6.0.0-beta.21314.1 + 6.0.0-beta.21314.1 + 6.0.0-beta.21314.1 + 6.0.0-beta.21314.1 + 6.0.0-beta.21314.1 - 1.0.0-prerelease.21313.4 - 1.0.0-prerelease.21313.4 - 1.0.0-prerelease.21313.4 - 1.0.0-prerelease.21313.4 + 1.0.0-prerelease.21320.4 + 1.0.0-prerelease.21320.4 + 1.0.0-prerelease.21320.4 + 1.0.0-prerelease.21320.4 16.9.0-beta1.21055.5 2.0.0-beta1.20253.1 @@ -148,9 +148,9 @@ 1.0.1-prerelease-00006 16.9.0-preview-20201201-01 - 1.0.0-prerelease.21314.1 - 1.0.0-prerelease.21314.1 - 1.0.1-alpha.0.21311.1 + 1.0.0-prerelease.21322.2 + 1.0.0-prerelease.21322.2 + 1.0.1-alpha.0.21314.1 2.4.1 2.4.2 1.3.0 @@ -161,19 +161,19 @@ 5.0.0-preview-20201009.2 - 6.0.100-preview.6.21310.3 + 6.0.100-preview.6.21317.4 $(MicrosoftNETILLinkTasksVersion) - 6.0.0-preview.6.21307.1 + 6.0.0-preview.7.21315.3 - 11.1.0-alpha.1.21308.1 - 11.1.0-alpha.1.21308.1 - 11.1.0-alpha.1.21308.1 - 11.1.0-alpha.1.21308.1 - 11.1.0-alpha.1.21308.1 - 11.1.0-alpha.1.21308.1 - 11.1.0-alpha.1.21308.1 - 11.1.0-alpha.1.21308.1 + 11.1.0-alpha.1.21314.1 + 11.1.0-alpha.1.21314.1 + 11.1.0-alpha.1.21314.1 + 11.1.0-alpha.1.21314.1 + 11.1.0-alpha.1.21314.1 + 11.1.0-alpha.1.21314.1 + 11.1.0-alpha.1.21314.1 + 11.1.0-alpha.1.21314.1 6.0.0-preview.6.21275.1 $(MicrosoftNETRuntimeEmscripten2021Nodewinx64Version) diff --git a/eng/common/generate-locproject.ps1 b/eng/common/generate-locproject.ps1 index de348a2e225c0..25e97ac00772d 100644 --- a/eng/common/generate-locproject.ps1 +++ b/eng/common/generate-locproject.ps1 @@ -25,8 +25,15 @@ Push-Location "$SourcesDirectory" # push location for Resolve-Path -Relative to # Template files $jsonFiles = @() -$jsonFiles += Get-ChildItem -Recurse -Path "$SourcesDirectory" | Where-Object { $_.FullName -Match "\.template\.config\\localize\\en\..+\.json" } # .NET templating pattern -$jsonFiles += Get-ChildItem -Recurse -Path "$SourcesDirectory" | Where-Object { $_.FullName -Match "en\\strings\.json" } # current winforms pattern +$jsonTemplateFiles = Get-ChildItem -Recurse -Path "$SourcesDirectory" | Where-Object { $_.FullName -Match "\.template\.config\\localize\\.+\.en\.json" } # .NET templating pattern +$jsonTemplateFiles | ForEach-Object { + $null = $_.Name -Match "(.+)\.[\w-]+\.json" # matches '[filename].[langcode].json + + $destinationFile = "$($_.Directory.FullName)\$($Matches.1).json" + $jsonFiles += Copy-Item "$($_.FullName)" -Destination $destinationFile -PassThru +} + +$jsonWinformsTemplateFiles = Get-ChildItem -Recurse -Path "$SourcesDirectory" | Where-Object { $_.FullName -Match "en\\strings\.json" } # current winforms pattern $xlfFiles = @() @@ -44,7 +51,7 @@ $langXlfFiles | ForEach-Object { $xlfFiles += Copy-Item "$($_.FullName)" -Destination $destinationFile -PassThru } -$locFiles = $jsonFiles + $xlfFiles +$locFiles = $jsonFiles + $jsonWinformsTemplateFiles + $xlfFiles $locJson = @{ Projects = @( diff --git a/eng/common/templates/job/source-index-stage1.yml b/eng/common/templates/job/source-index-stage1.yml index 6e8aa9f7f218b..b58d42364b9e7 100644 --- a/eng/common/templates/job/source-index-stage1.yml +++ b/eng/common/templates/job/source-index-stage1.yml @@ -7,9 +7,13 @@ parameters: binlogPath: artifacts/log/Debug/Build.binlog pool: vmImage: vs2017-win2016 + condition: '' + dependsOn: '' jobs: - job: SourceIndexStage1 + dependsOn: ${{ parameters.dependsOn }} + condition: ${{ parameters.condition }} variables: - name: SourceIndexPackageVersion value: ${{ parameters.sourceIndexPackageVersion }} diff --git a/global.json b/global.json index df8f7ead63774..433797e811628 100644 --- a/global.json +++ b/global.json @@ -12,13 +12,13 @@ "python3": "3.7.1" }, "msbuild-sdks": { - "Microsoft.DotNet.Build.Tasks.TargetFramework.Sdk": "6.0.0-beta.21311.3", + "Microsoft.DotNet.Build.Tasks.TargetFramework.Sdk": "6.0.0-beta.21321.1", "Microsoft.DotNet.PackageValidation": "1.0.0-preview.6.21274.7", - "Microsoft.DotNet.Arcade.Sdk": "6.0.0-beta.21311.3", - "Microsoft.DotNet.Helix.Sdk": "6.0.0-beta.21311.3", - "Microsoft.DotNet.SharedFramework.Sdk": "6.0.0-beta.21311.3", + "Microsoft.DotNet.Arcade.Sdk": "6.0.0-beta.21321.1", + "Microsoft.DotNet.Helix.Sdk": "6.0.0-beta.21321.1", + "Microsoft.DotNet.SharedFramework.Sdk": "6.0.0-beta.21321.1", "Microsoft.Build.NoTargets": "3.0.4", "Microsoft.Build.Traversal": "3.0.23", - "Microsoft.NET.Sdk.IL": "6.0.0-preview.6.21314.1" + "Microsoft.NET.Sdk.IL": "6.0.0-preview.7.21321.2" } } diff --git a/src/libraries/System.Data.Odbc/src/ILLink/ILLink.Suppressions.xml b/src/libraries/System.Data.Odbc/src/ILLink/ILLink.Suppressions.xml index 533fc1cd0ed04..0504df00e7659 100644 --- a/src/libraries/System.Data.Odbc/src/ILLink/ILLink.Suppressions.xml +++ b/src/libraries/System.Data.Odbc/src/ILLink/ILLink.Suppressions.xml @@ -5,7 +5,7 @@ ILLink IL2050 member - M:Interop.Odbc.SQLSetConnectAttrW(System.Data.Odbc.OdbcConnectionHandle,System.Data.Odbc.ODBC32.SQL_ATTR,System.Transactions.IDtcTransaction,System.Int32) + M:System.Data.Odbc.OdbcConnectionHandle.SetConnectionAttribute4(System.Data.Odbc.ODBC32.SQL_ATTR,System.Transactions.IDtcTransaction,System.Int32) ILLink diff --git a/src/libraries/System.Data.OleDb/src/ILLink/ILLink.Suppressions.xml b/src/libraries/System.Data.OleDb/src/ILLink/ILLink.Suppressions.xml index 2e52a33c8a98e..5386e4bd294fc 100644 --- a/src/libraries/System.Data.OleDb/src/ILLink/ILLink.Suppressions.xml +++ b/src/libraries/System.Data.OleDb/src/ILLink/ILLink.Suppressions.xml @@ -5,7 +5,25 @@ ILLink IL2050 member - M:System.Data.Common.UnsafeNativeMethods.GetErrorInfo(System.Int32,System.Data.Common.UnsafeNativeMethods.IErrorInfo@) + M:System.Data.OleDb.DBPropSet.SetLastErrorInfo(System.Data.OleDb.OleDbHResult) + + + ILLink + IL2050 + member + M:System.Data.OleDb.OleDbConnection.ProcessResults(System.Data.OleDb.OleDbHResult,System.Data.OleDb.OleDbConnection,System.Object) + + + ILLink + IL2050 + member + M:System.Data.OleDb.OleDbDataAdapter.FillClose(System.Boolean,System.Object) + + + ILLink + IL2050 + member + M:System.Data.OleDb.OleDbDataAdapter.FillFromADODB(System.Object,System.Object,System.String,System.Boolean) ILLink diff --git a/src/libraries/System.DirectoryServices.AccountManagement/src/ILLink/ILLink.Suppressions.xml b/src/libraries/System.DirectoryServices.AccountManagement/src/ILLink/ILLink.Suppressions.xml index ae9db1185dd9c..7572cc7074afb 100644 --- a/src/libraries/System.DirectoryServices.AccountManagement/src/ILLink/ILLink.Suppressions.xml +++ b/src/libraries/System.DirectoryServices.AccountManagement/src/ILLink/ILLink.Suppressions.xml @@ -5,7 +5,7 @@ ILLink IL2050 member - M:System.DirectoryServices.AccountManagement.UnsafeNativeMethods.IntADsOpenObject(System.String,System.String,System.String,System.Int32,System.Guid@,System.Object@) + M:System.DirectoryServices.AccountManagement.UnsafeNativeMethods.ADsOpenObject(System.String,System.String,System.String,System.Int32,System.Guid@,System.Object@) ILLink diff --git a/src/libraries/System.DirectoryServices/src/ILLink/ILLink.Suppressions.xml b/src/libraries/System.DirectoryServices/src/ILLink/ILLink.Suppressions.xml index 0e87e736269c4..ca9681a8e8f63 100644 --- a/src/libraries/System.DirectoryServices/src/ILLink/ILLink.Suppressions.xml +++ b/src/libraries/System.DirectoryServices/src/ILLink/ILLink.Suppressions.xml @@ -5,7 +5,7 @@ ILLink IL2050 member - M:System.DirectoryServices.Interop.UnsafeNativeMethods.IntADsOpenObject(System.String,System.String,System.String,System.Int32,System.Guid@,System.Object@) + M:System.DirectoryServices.Interop.UnsafeNativeMethods.ADsOpenObject(System.String,System.String,System.String,System.Int32,System.Guid@,System.Object@) ILLink diff --git a/src/libraries/System.Drawing.Common/src/ILLink/ILLink.Suppressions.xml b/src/libraries/System.Drawing.Common/src/ILLink/ILLink.Suppressions.xml index d5734aab1a2a9..3f367cccd2496 100644 --- a/src/libraries/System.Drawing.Common/src/ILLink/ILLink.Suppressions.xml +++ b/src/libraries/System.Drawing.Common/src/ILLink/ILLink.Suppressions.xml @@ -5,67 +5,61 @@ ILLink IL2050 member - M:System.Drawing.Icon.OleCreatePictureIndirect(System.Drawing.Icon.PICTDESC,System.Guid@,System.Boolean) + M:System.Drawing.Bitmap.#ctor(System.IO.Stream,System.Boolean) ILLink IL2050 member - M:System.Drawing.SafeNativeMethods.Gdip.GdipCreateBitmapFromStream(Interop.Ole32.IStream,System.IntPtr@) + M:System.Drawing.Icon.Save(System.IO.Stream) ILLink IL2050 member - M:System.Drawing.SafeNativeMethods.Gdip.GdipCreateBitmapFromStreamICM(Interop.Ole32.IStream,System.IntPtr@) + M:System.Drawing.Image.FromStream(System.IO.Stream,System.Boolean,System.Boolean) ILLink IL2050 member - M:System.Drawing.SafeNativeMethods.Gdip.GdipCreateMetafileFromStream(Interop.Ole32.IStream,System.IntPtr@) + M:System.Drawing.Image.InitializeFromStream(System.IO.Stream) ILLink IL2050 member - M:System.Drawing.SafeNativeMethods.Gdip.GdipGetMetafileHeaderFromStream(Interop.Ole32.IStream,System.IntPtr) + M:System.Drawing.Image.Save(System.IO.Stream,System.Drawing.Imaging.ImageCodecInfo,System.Drawing.Imaging.EncoderParameters) ILLink IL2050 member - M:System.Drawing.SafeNativeMethods.Gdip.GdipLoadImageFromStream(Interop.Ole32.IStream,System.IntPtr@) + M:System.Drawing.Imaging.Metafile.#ctor(System.IO.Stream,System.IntPtr,System.Drawing.Imaging.EmfType,System.String) ILLink IL2050 member - M:System.Drawing.SafeNativeMethods.Gdip.GdipLoadImageFromStreamICM(Interop.Ole32.IStream,System.IntPtr@) + M:System.Drawing.Imaging.Metafile.#ctor(System.IO.Stream,System.IntPtr,System.Drawing.Rectangle,System.Drawing.Imaging.MetafileFrameUnit,System.Drawing.Imaging.EmfType,System.String) ILLink IL2050 member - M:System.Drawing.SafeNativeMethods.Gdip.GdipRecordMetafileStream(Interop.Ole32.IStream,System.IntPtr,System.Drawing.Imaging.EmfType,System.Drawing.RectangleF@,System.Drawing.Imaging.MetafileFrameUnit,System.String,System.IntPtr@) + M:System.Drawing.Imaging.Metafile.#ctor(System.IO.Stream,System.IntPtr,System.Drawing.RectangleF,System.Drawing.Imaging.MetafileFrameUnit,System.Drawing.Imaging.EmfType,System.String) ILLink IL2050 member - M:System.Drawing.SafeNativeMethods.Gdip.GdipRecordMetafileStream(Interop.Ole32.IStream,System.IntPtr,System.Drawing.Imaging.EmfType,System.IntPtr,System.Drawing.Imaging.MetafileFrameUnit,System.String,System.IntPtr@) + M:System.Drawing.Imaging.Metafile.#ctor(System.IO.Stream) ILLink IL2050 member - M:System.Drawing.SafeNativeMethods.Gdip.GdipRecordMetafileStreamI(Interop.Ole32.IStream,System.IntPtr,System.Drawing.Imaging.EmfType,System.Drawing.Rectangle@,System.Drawing.Imaging.MetafileFrameUnit,System.String,System.IntPtr@) - - - ILLink - IL2050 - member - M:System.Drawing.SafeNativeMethods.Gdip.GdipSaveImageToStream(System.Runtime.InteropServices.HandleRef,Interop.Ole32.IStream,System.Guid@,System.Runtime.InteropServices.HandleRef) + M:System.Drawing.Imaging.Metafile.GetMetafileHeader(System.IO.Stream) diff --git a/src/libraries/pkg/test/testPackages.proj b/src/libraries/pkg/test/testPackages.proj index 03492c30ee0f9..83ad6233b6432 100644 --- a/src/libraries/pkg/test/testPackages.proj +++ b/src/libraries/pkg/test/testPackages.proj @@ -75,7 +75,7 @@ - + From 2f5a14d3efd0b97d58144c353019f61e6a9be5ef Mon Sep 17 00:00:00 2001 From: Premek Vysoky Date: Wed, 23 Jun 2021 19:43:53 +0200 Subject: [PATCH 2/6] Remove the --app argument from android run --- src/tests/Common/CLRTest.Execute.Bash.targets | 2 +- src/tests/Common/CLRTest.Execute.Batch.targets | 2 +- src/tests/Common/Coreclr.TestWrapper/MobileAppHandler.cs | 2 +- 3 files changed, 3 insertions(+), 3 deletions(-) diff --git a/src/tests/Common/CLRTest.Execute.Bash.targets b/src/tests/Common/CLRTest.Execute.Bash.targets index cb28cbfac5e5a..d44f83d429204 100644 --- a/src/tests/Common/CLRTest.Execute.Bash.targets +++ b/src/tests/Common/CLRTest.Execute.Bash.targets @@ -361,7 +361,7 @@ else HARNESS_RUNNER="xharness" fi -$__Command $HARNESS_RUNNER android run --instrumentation="net.dot.MonoRunner" --package-name="net.dot.$__Category" --app="$__TestBinaryBase/$__Category.apk" --output-directory="$__OutputDir" --arg=entrypoint:libname=$(MsBuildProjectName).dll --expected-exit-code=100 -v +$__Command $HARNESS_RUNNER android run --instrumentation="net.dot.MonoRunner" --package-name="net.dot.$__Category" --output-directory="$__OutputDir" --arg=entrypoint:libname=$(MsBuildProjectName).dll --expected-exit-code=100 -v CLRTestExitCode=$? # Exist code of xharness is zero when tests finished successfully diff --git a/src/tests/Common/CLRTest.Execute.Batch.targets b/src/tests/Common/CLRTest.Execute.Batch.targets index bdebae3acdadf..24081762e9fe0 100644 --- a/src/tests/Common/CLRTest.Execute.Batch.targets +++ b/src/tests/Common/CLRTest.Execute.Batch.targets @@ -329,7 +329,7 @@ IF NOT "%XHARNESS_CLI_PATH%"=="" ( set HARNESS_RUNNER=xharness ) -%__Command% %HARNESS_RUNNER% android run --instrumentation="net.dot.MonoRunner" --package-name="net.dot.%__Category%" --app="%__TestBinaryBase%\%__Category%.apk" --output-directory="%__OutputDir%" --arg=entrypoint:libname=$(MsBuildProjectName).dll --expected-exit-code=100 -v +%__Command% %HARNESS_RUNNER% android run --instrumentation="net.dot.MonoRunner" --package-name="net.dot.%__Category%" --output-directory="%__OutputDir%" --arg=entrypoint:libname=$(MsBuildProjectName).dll --expected-exit-code=100 -v set CLRTestExitCode=!ERRORLEVEL! set CLRTestExpectedExitCode=0 ]]> diff --git a/src/tests/Common/Coreclr.TestWrapper/MobileAppHandler.cs b/src/tests/Common/Coreclr.TestWrapper/MobileAppHandler.cs index 7a80d1e2b3b7a..9b7596bc31515 100644 --- a/src/tests/Common/Coreclr.TestWrapper/MobileAppHandler.cs +++ b/src/tests/Common/Coreclr.TestWrapper/MobileAppHandler.cs @@ -58,7 +58,7 @@ private static void HandleMobileApp(string action, string platform, string categ appExtension = "app"; } - cmdStr = $"{dotnetCmd} {xharnessCmd} {platform} {action} --package-name=net.dot.{category} --app={testBinaryBase}/{category}.{appExtension} --output-directory={reportBase}/install"; + cmdStr = $"{dotnetCmd} {xharnessCmd} {platform} {action} --package-name=net.dot.{category} --output-directory={reportBase}/install"; Directory.CreateDirectory(Path.Combine(reportBase, action)); var outputStream = new FileStream(outputFile, FileMode.Create); From 48ce4ff793fd092259346ee9d9fab4f55c87dc47 Mon Sep 17 00:00:00 2001 From: Premek Vysoky Date: Thu, 24 Jun 2021 10:15:31 +0200 Subject: [PATCH 3/6] Handle the install command --- src/tests/Common/Coreclr.TestWrapper/MobileAppHandler.cs | 9 ++++++++- 1 file changed, 8 insertions(+), 1 deletion(-) diff --git a/src/tests/Common/Coreclr.TestWrapper/MobileAppHandler.cs b/src/tests/Common/Coreclr.TestWrapper/MobileAppHandler.cs index 1aa6afa15edc3..5ee221ac4e026 100644 --- a/src/tests/Common/Coreclr.TestWrapper/MobileAppHandler.cs +++ b/src/tests/Common/Coreclr.TestWrapper/MobileAppHandler.cs @@ -58,7 +58,14 @@ private static void HandleMobileApp(string action, string platform, string categ appExtension = "app"; } - cmdStr = $"{dotnetCmd} {xharnessCmd} {platform} {action} --package-name=net.dot.{category} --output-directory={reportBase}/install"; + if(action == "install") + { + cmdStr = $"{dotnetCmd} {xharnessCmd} {platform} {action} --app={testBinaryBase}/{category}.{appExtension} --package-name=net.dot.{category} --output-directory={reportBase}/install"; + } + else + { + cmdStr = $"{dotnetCmd} {xharnessCmd} {platform} {action} --package-name=net.dot.{category} --output-directory={reportBase}/install"; + } Directory.CreateDirectory(Path.Combine(reportBase, action)); var outputStream = new FileStream(outputFile, FileMode.Create); From e1fa16e1934343d0eb4903a174f9ea326eb3e7c9 Mon Sep 17 00:00:00 2001 From: Premek Vysoky Date: Thu, 24 Jun 2021 13:16:35 +0200 Subject: [PATCH 4/6] Bump XHarness to 1.0.0-prerelease.21322.2 (WASM fixes) --- .config/dotnet-tools.json | 2 +- eng/Version.Details.xml | 8 ++++---- eng/Versions.props | 4 ++-- 3 files changed, 7 insertions(+), 7 deletions(-) diff --git a/.config/dotnet-tools.json b/.config/dotnet-tools.json index 6428121a0fec7..b012e3ae62fed 100644 --- a/.config/dotnet-tools.json +++ b/.config/dotnet-tools.json @@ -15,7 +15,7 @@ ] }, "microsoft.dotnet.xharness.cli": { - "version": "1.0.0-prerelease.21322.2", + "version": "1.0.0-prerelease.21324.1", "commands": [ "xharness" ] diff --git a/eng/Version.Details.xml b/eng/Version.Details.xml index 716cd24c6fe92..32891a8228bc6 100644 --- a/eng/Version.Details.xml +++ b/eng/Version.Details.xml @@ -178,13 +178,13 @@ https://github.com/mono/linker c739a81ba553b00df1cb2f5b9974deae996b757a - + https://github.com/dotnet/xharness - 0bb4a23b1b686e8fefde9d4c860b26a8fafc303e + fed4184ebd3315ca717339b2f751693ef8dabd36 - + https://github.com/dotnet/xharness - 0bb4a23b1b686e8fefde9d4c860b26a8fafc303e + fed4184ebd3315ca717339b2f751693ef8dabd36 https://github.com/dotnet/arcade diff --git a/eng/Versions.props b/eng/Versions.props index 924d681058fe8..f0d11e6180955 100644 --- a/eng/Versions.props +++ b/eng/Versions.props @@ -149,8 +149,8 @@ 1.0.1-prerelease-00006 16.9.0-preview-20201201-01 - 1.0.0-prerelease.21322.2 - 1.0.0-prerelease.21322.2 + 1.0.0-prerelease.21324.1 + 1.0.0-prerelease.21324.1 1.0.1-alpha.0.21314.1 2.4.1 2.4.2 From 9819d8f25b4a336c18a8b01d07de36e069a640af Mon Sep 17 00:00:00 2001 From: Premek Vysoky Date: Thu, 24 Jun 2021 16:25:45 +0200 Subject: [PATCH 5/6] Bump XHarness to 1.0.0-prerelease.21324.1 (WASM fixes) --- .config/dotnet-tools.json | 2 +- eng/Version.Details.xml | 8 ++++---- eng/Versions.props | 4 ++-- 3 files changed, 7 insertions(+), 7 deletions(-) diff --git a/.config/dotnet-tools.json b/.config/dotnet-tools.json index b012e3ae62fed..14ccd5e0cfd80 100644 --- a/.config/dotnet-tools.json +++ b/.config/dotnet-tools.json @@ -15,7 +15,7 @@ ] }, "microsoft.dotnet.xharness.cli": { - "version": "1.0.0-prerelease.21324.1", + "version": "1.0.0-prerelease.21324.2", "commands": [ "xharness" ] diff --git a/eng/Version.Details.xml b/eng/Version.Details.xml index 32891a8228bc6..f3b4a792aa301 100644 --- a/eng/Version.Details.xml +++ b/eng/Version.Details.xml @@ -178,13 +178,13 @@ https://github.com/mono/linker c739a81ba553b00df1cb2f5b9974deae996b757a - + https://github.com/dotnet/xharness - fed4184ebd3315ca717339b2f751693ef8dabd36 + 49b0eedd8ecb0dea7e00c89097a5cd0f1f584257 - + https://github.com/dotnet/xharness - fed4184ebd3315ca717339b2f751693ef8dabd36 + 49b0eedd8ecb0dea7e00c89097a5cd0f1f584257 https://github.com/dotnet/arcade diff --git a/eng/Versions.props b/eng/Versions.props index f0d11e6180955..081829f2c3497 100644 --- a/eng/Versions.props +++ b/eng/Versions.props @@ -149,8 +149,8 @@ 1.0.1-prerelease-00006 16.9.0-preview-20201201-01 - 1.0.0-prerelease.21324.1 - 1.0.0-prerelease.21324.1 + 1.0.0-prerelease.21324.2 + 1.0.0-prerelease.21324.2 1.0.1-alpha.0.21314.1 2.4.1 2.4.2 From f76ee876076e879b5b786e92cafab8af4dcb6413 Mon Sep 17 00:00:00 2001 From: Premek Vysoky Date: Thu, 24 Jun 2021 16:49:13 +0200 Subject: [PATCH 6/6] Improve how we build the xharness command --- .../Coreclr.TestWrapper/MobileAppHandler.cs | 41 +++++-------------- 1 file changed, 10 insertions(+), 31 deletions(-) diff --git a/src/tests/Common/Coreclr.TestWrapper/MobileAppHandler.cs b/src/tests/Common/Coreclr.TestWrapper/MobileAppHandler.cs index 5ee221ac4e026..b594455f1071c 100644 --- a/src/tests/Common/Coreclr.TestWrapper/MobileAppHandler.cs +++ b/src/tests/Common/Coreclr.TestWrapper/MobileAppHandler.cs @@ -24,47 +24,26 @@ private static void HandleMobileApp(string action, string platform, string categ string outputFile = Path.Combine(reportBase, action, $"{category}_{action}.output.txt"); string errorFile = Path.Combine(reportBase, action, $"{category}_{action}.error.txt"); string dotnetCmd_raw = System.Environment.GetEnvironmentVariable("__TestDotNetCmd"); - string dotnetCmd; string xharnessCmd_raw = System.Environment.GetEnvironmentVariable("XHARNESS_CLI_PATH"); - string xharnessCmd; - string cmdStr; - string appExtension; int timeout = 600000; // Set timeout to 4 mins, because the installation on Android arm64/32 devices could take up to 10 mins on CI - if(String.IsNullOrEmpty(dotnetCmd_raw)) - { - dotnetCmd = "dotnet"; - } - else - { - dotnetCmd = dotnetCmd_raw; - } + string dotnetCmd = string.IsNullOrEmpty(dotnetCmd_raw) ? "dotnet" : dotnetCmd_raw; + string xharnessCmd = string.IsNullOrEmpty(xharnessCmd_raw) ? "xharness" : $"exec {xharnessCmd_raw}"; + string appExtension = platform == "android" ? "apk" : "app"; + string cmdStr = $"{dotnetCmd} {xharnessCmd} {platform} {action} --output-directory={reportBase}/{action}"; - if(String.IsNullOrEmpty(xharnessCmd_raw)) + if (action == "install") { - xharnessCmd = "xharness"; + cmdStr += $" --app={testBinaryBase}/{category}.{appExtension}"; } - else + else if (platform != "android") { - xharnessCmd = $"exec {xharnessCmd_raw}"; + cmdStr += $" --app=net.dot.{category}"; } - if(platform == "android") - { - appExtension = "apk"; - } - else - { - appExtension = "app"; - } - - if(action == "install") - { - cmdStr = $"{dotnetCmd} {xharnessCmd} {platform} {action} --app={testBinaryBase}/{category}.{appExtension} --package-name=net.dot.{category} --output-directory={reportBase}/install"; - } - else + if (platform == "android") { - cmdStr = $"{dotnetCmd} {xharnessCmd} {platform} {action} --package-name=net.dot.{category} --output-directory={reportBase}/install"; + cmdStr += $" --package-name=net.dot.{category}"; } Directory.CreateDirectory(Path.Combine(reportBase, action));