Reduce size of HttpHeaderValueCollection #63057
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 8 commits
December 21, 2021 12:06
ghost
assigned 
|
Tagging subscribers to this area: @dotnet/ncl Issue DetailsRemove the _validator field by replacing with a check for GenericHeaderParser.TokenListParser, since this is the only thing validators were used for. Remove the _specialValue field by pushing handling of special values to callers.
|
MihaZupan
approved these changes
Dec 22, 2021
stephentoub
reviewed
Jan 3, 2022
| @@ -22,8 +22,7 @@ public ICollection<string> Allow | |||
| { | |||
| if (_allow == null) | |||
| { | |||
| _allow = new HttpHeaderValueCollection<string>(KnownHeaders.Allow.Descriptor, | |||
| this, HeaderUtilities.TokenValidator); | |||
| _allow = new HttpHeaderValueCollection<string>(KnownHeaders.Allow.Descriptor, this); | |||
| } | |||
| return _allow; | |||
| } | |||
There was a problem hiding this comment.
For future cleanup, this can be simplified to just:
public ICollection<string> Allow => _allow ??= new HttpHeaderValueCollection<string>(KnownHeaders.Allow.Descriptor, this);Same for some other props below.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove the _validator field by replacing with a check for GenericHeaderParser.TokenListParser, since this is the only thing validators were used for.
Remove the _specialValue field by pushing handling of special values to callers.
Fixes #63054
Fixes #63050