Remove hash work in RsaPaddingProcessor.OpenProcessor. #68553
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was hashing data to determine the length of the hash. But we know MD5 is always going to be 16, SHA1 is going to be 20, etc. so don't waste any time hashing anything.
ghost
assigned 
|
Tagging subscribers to this area: @dotnet/area-system-security, @vcsjones Issue DetailsThis was hashing data to determine the length of the hash. But we know MD5 is always going to be 16, SHA1 is going to be 20, etc. so don't waste any time hashing anything. Best reviewing ignoring whitespace.
|
|
Looks good, except for the build failures 😄. |
Picky! |
stephentoub
approved these changes
Apr 26, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was hashing data to determine the length of the hash. But we know MD5 is always going to be 16, SHA1 is going to be 20, etc. so don't waste any time hashing anything.
Best reviewed ignoring whitespace.