Skip to content

Add missing const qualifier to hosting API implementation #73404

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 5, 2022
Merged

Add missing const qualifier to hosting API implementation #73404

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/native/corehost/hostpolicy/hostpolicy.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -301,7 +301,7 @@ void trace_hostpolicy_entrypoint_invocation(const pal::string_t& entryPointName)
// If hostpolicy is already initialized, the library will not be
// reinitialized.
//
SHARED_API int HOSTPOLICY_CALLTYPE corehost_load(host_interface_t* init)
SHARED_API int HOSTPOLICY_CALLTYPE corehost_load(const host_interface_t* init)
{
assert(init != nullptr);
std::lock_guard<std::mutex> lock{ g_init_lock };
Expand Down
8 changes: 4 additions & 4 deletions src/native/corehost/hostpolicy/hostpolicy_init.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ void make_palstr_arr(size_t argc, const pal::char_t** argv, std::vector<pal::str
}
}

bool hostpolicy_init_t::init(host_interface_t* input, hostpolicy_init_t* init)
bool hostpolicy_init_t::init(const host_interface_t* input, hostpolicy_init_t* init)
{
// Check if there are any breaking changes.
if (input->version_hi != HOST_INTERFACE_LAYOUT_VERSION_HI)
Expand Down Expand Up @@ -46,7 +46,7 @@ bool hostpolicy_init_t::init(host_interface_t* input, hostpolicy_init_t* init)
}
else
{
trace::error(_X("The size of the data layout used to initialize %s is %zd; expected at least %d"), LIBHOSTPOLICY_NAME, input->version_lo,
trace::error(_X("The size of the data layout used to initialize %s is %zd; expected at least %d"), LIBHOSTPOLICY_NAME, input->version_lo,
offsetof(host_interface_t, host_mode) + sizeof(input->host_mode));
}

Expand All @@ -57,7 +57,7 @@ bool hostpolicy_init_t::init(host_interface_t* input, hostpolicy_init_t* init)
{
init->tfm = input->tfm;
}

if (input->version_lo >= offsetof(host_interface_t, fx_ver) + sizeof(input->fx_ver))
{
init->additional_deps_serialized = input->additional_deps_serialized;
Expand Down Expand Up @@ -138,7 +138,7 @@ bool hostpolicy_init_t::init(host_interface_t* input, hostpolicy_init_t* init)
return true;
}

void hostpolicy_init_t::init_host_command(host_interface_t* input, hostpolicy_init_t* init)
void hostpolicy_init_t::init_host_command(const host_interface_t* input, hostpolicy_init_t* init)
{
if (input->version_lo >= offsetof(host_interface_t, host_command) + sizeof(input->host_command))
{
Expand Down
4 changes: 2 additions & 2 deletions src/native/corehost/hostpolicy/hostpolicy_init.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,9 +25,9 @@ struct hostpolicy_init_t
pal::string_t host_command;
host_startup_info_t host_info;

static bool init(host_interface_t* input, hostpolicy_init_t* init);
static bool init(const host_interface_t* input, hostpolicy_init_t* init);

static void init_host_command(host_interface_t* input, hostpolicy_init_t* init);
static void init_host_command(const host_interface_t* input, hostpolicy_init_t* init);
};

#endif // __HOSTPOLICY_INIT_H__