Skip to content

PEReader doesn't work with "IsLoadedImage" and "PrefetchMetadata" options #80106

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jan 13, 2023
Merged

PEReader doesn't work with "IsLoadedImage" and "PrefetchMetadata" options #80106

merged 3 commits into from
Jan 13, 2023

Conversation

@pedrobsaila
Copy link
Contributor

Fixes #76648

@ghost ghost added area-System.Reflection.Metadata community-contribution Indicates that the PR has been added by a community member labels Jan 2, 2023
@ghost
Copy link

ghost commented Jan 2, 2023

Tagging subscribers to this area: @dotnet/area-system-reflection-metadata
See info in area-owners.md if you want to be subscribed.

Issue Details

Fixes #76648

Author: pedrobsaila
Assignees: -
Labels:

area-System.Reflection.Metadata
Milestone: -

@build-analysis build-analysis bot mentioned this pull request Jan 3, 2023
Closed
@buyaa-n @MartyIX
Apply suggestions from code review
af95f1c 
Co-authored-by: MartyIX <203266+MartyIX@users.noreply.github.com>
@build-analysis build-analysis bot mentioned this pull request Jan 12, 2023
Closed
@build-analysis build-analysis bot mentioned this pull request Jan 12, 2023
Closed
buyaa-n
buyaa-n approved these changes Jan 13, 2023
View reviewed changes
Copy link
Contributor

@buyaa-n buyaa-n left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you @pedrobsaila!

@buyaa-n buyaa-n merged commit 8823520 into dotnet:main Jan 13, 2023
@pedrobsaila pedrobsaila deleted the 76648 branch January 14, 2023 11:10
@ghost ghost locked as resolved and limited conversation to collaborators Feb 13, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

2 more reviewers

@MartyIX MartyIX MartyIX left review comments

@buyaa-n buyaa-n buyaa-n approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

area-System.Reflection.Metadata community-contribution Indicates that the PR has been added by a community member

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

PEReader doesn't work with "IsLoadedImage" and "PrefetchMetadata" options

3 participants

@pedrobsaila @MartyIX @buyaa-n