Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"salt" MSBuild handshake in test / dogfood environment #2880

Open
dsplaisted opened this Issue Jan 29, 2019 · 3 comments

Comments

Projects
None yet
2 participants
@dsplaisted
Copy link
Member

dsplaisted commented Jan 29, 2019

Right now for our tests (and in the dogfood script) we override the MSBuildSDKsPath to point MSBuild to the SDK under test. However, this doesn't seem to prevent sharing MSBuild nodes that didn't have this set, which can end up causing assembly loading or other issues.

Ideally in our test environment we would add a "salt" to the node connection handshake, so that MSBuild would only be able to connect to nodes that come from the same test environment.

This would probably require a change in MSBuild to allow us to provide such a "salt".

@rainersigwald, thoughts?

@rainersigwald

This comment has been minimized.

Copy link
Contributor

rainersigwald commented Jan 29, 2019

I'd be on board with adding the value of a MSBUILDNODEHANDSHAKESALT environment variable to the handshake. I don't think it's generally useful, but for internal development and especially tests that require multiple invocations and need node reuse to be enabled it'd be nice.

@rainersigwald

This comment has been minimized.

Copy link
Contributor

rainersigwald commented Apr 15, 2019

This issue was moved to Microsoft/msbuild#4308

@rainersigwald

This comment has been minimized.

Copy link
Contributor

rainersigwald commented Apr 15, 2019

Reopening to track adopting Microsoft/msbuild#4308 once it's available.

@rainersigwald rainersigwald reopened this Apr 15, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.