Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Microsoft.NET.Build.Extensions.Tasks.dll should not be loaded in devenv projecc during reference resolution for native vc projects #3585

Closed
olgaark opened this issue Aug 28, 2019 · 2 comments
Milestone

Comments

@olgaark
Copy link

@olgaark olgaark commented Aug 28, 2019

The problem is found while investigating
VS Bug 973252: Perf: CPlusPlus_DDRIT.0900.Close Solution regressed VM_AdjustedImagesInMemory_Total_devenv by 2.000 Count (0.5%). Baseline 29226.70

Microsoft.NET.Build.Extensions.Tasks.dll is loaded by _HandlePackageFileConflicts target during

Target Name=ResolveAssemblyReferences Project=ConsoleApplication1.vcxproj  note that there is no assembly references in the native vc project

Target Name=_HandlePackageFileConflicts Project=ConsoleApplication1.vcxproj

The target is implemented here:

f:\Visual Studio 16 Master\MSBuild\Microsoft\Microsoft.NET.Build.Extensions\Microsoft.NET.Build.Extensions.ConflictResolution.targets

-->






Is this target doing something applicable to vc projects? If not, please either disable it for vcxproj or add a condition so cpp targets can disable it.
At least, please add a condition there for empty @(Reference) so the task dll is not loaded in this case.

@livarcocc

This comment has been minimized.

Copy link
Contributor

@livarcocc livarcocc commented Aug 29, 2019

@dsplaisted can you take a look?

@livarcocc livarcocc added this to the 3.1.1xx milestone Aug 29, 2019
@dsplaisted

This comment has been minimized.

Copy link
Member

@dsplaisted dsplaisted commented Aug 30, 2019

@olgaark Can you provide a sample VC project where this is occurring? Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.