Skip to content

Revise CreateFromFilteredSolutionFile implementation for trailing comma (and allowing comments) #51929

@Youssef1313

Description

@Youssef1313

The current implementation of this method doesn't seem to allow trailing commas (and comments).

MSBuild supported trailing commas (and comments) of slnf files in dotnet/msbuild#6346

JsonElement root = JsonDocument.Parse(File.ReadAllText(filteredSolutionPath)).RootElement;

@baronfel @rainersigwald Another discrepancy due to not having a unified implementation/helper for how to parse solutions and solution filters. Not specific to test command this time :)

Metadata

Metadata

Assignees

Labels

untriagedRequest triage from a team member

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions