Use Process.Kill(true) instead of KillTree #15821
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I couldn't figure out the best area label to add to this PR. If you have write-permissions please help me learn by adding exactly one area label. |
|
I'm going to yolo this for 6.0. We can see what falls out of it. |
jkotalik
approved these changes
Feb 11, 2021
|
linking dotnet/runtime#45017 |
|
@danmoseley I tried this change in the ASP.NET Core repo: dotnet/aspnetcore#29016 but had to cancel that PR because the change caused some tests (that attempt to process-kill) to hang indefinitely. dotnet-watch has tests that verify the process it launches is killed, but none that verifies that a graph of processes is cleaned up. But preview2 is as good as any release to get customer feeedback on this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.