Rename SDK build directory to "targets" in source and layout #1985
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dsplaisted
force-pushed
the
1071-rename-build-directory
branch
from
0c0ef21
to
b6c28e6
Compare
nguerrera
reviewed
Feb 23, 2018
| <None Include="..\Common\Resources\xlf\**\*" LinkBase="Resources\xlf" /> | ||
| </ItemGroup> | ||
|
|
||
| <ItemGroup> | ||
| <Folder Include="buildCrossTargeting\" /> |
nguerrera
approved these changes
Feb 23, 2018
…ssTargeting folder
dsplaisted
force-pushed
the
1071-rename-build-directory
branch
from
b6c28e6
to
e301331
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This renames the build folder (not at the root of the repo, but the one with the Microsoft.NET.Sdk targets) to "targets". This is mostly because GitHub code search and file finder ignore files in a folder named build.
This also gets rid of the buildCrossTargeting folder, by renaming
buildCrossTargeting/Microsoft.NET.Sdk.targetstotargets/Microsoft.NET.Sdk.CrossTargeting.targets.@nguerrera had concerns that renaming these files would cause merge conflicts when integrating changes to the renamed files from other branches, but I tried this out locally with some simple changes and they automatically merged correctly.
Fixes #1071