Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Blazor] Handle _GlobalPropertiesToRemoveFromProjectReferences in the SDK #27057

Merged
merged 1 commit into from Aug 10, 2022
Merged

[Blazor] Handle _GlobalPropertiesToRemoveFromProjectReferences in the SDK #27057

merged 1 commit into from Aug 10, 2022

Conversation

TanayParikh
Copy link
Contributor

@TanayParikh TanayParikh added the Area-AspNetCore RazorSDK, BlazorWebAssemblySDK, dotnet-watch label Aug 9, 2022
@TanayParikh TanayParikh added this to the 7.0.1xx milestone Aug 9, 2022
@TanayParikh TanayParikh self-assigned this Aug 9, 2022
@TanayParikh TanayParikh marked this pull request as ready for review August 10, 2022 15:27
@TanayParikh TanayParikh requested review from javiercn and a team August 10, 2022 15:27
javiercn
javiercn approved these changes Aug 10, 2022
View reviewed changes
Copy link
Member

@javiercn javiercn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, provided the tests pass.

@TanayParikh TanayParikh merged commit 11d34cb into main Aug 10, 2022
@TanayParikh TanayParikh deleted the taparik/fixRCLGlobalProperties branch August 10, 2022 15:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@javiercn javiercn javiercn approved these changes

@captainsafia captainsafia Awaiting requested review from captainsafia

@mkArtakMSFT mkArtakMSFT Awaiting requested review from mkArtakMSFT

Assignees

@TanayParikh TanayParikh

Labels
Area-AspNetCore RazorSDK, BlazorWebAssemblySDK, dotnet-watch
Projects
None yet
Milestone
7.0.1xx
Development

Successfully merging this pull request may close these issues.

[Blazor] Handle _GlobalPropertiesToRemoveFromProjectReferences in the SDK
2 participants
@TanayParikh @javiercn