Quote file paths for the BrotliCompress tool #27213
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
the
…ndLine token-expansion rules
baronfel
force-pushed
the
quote-file-paths-in-brotli-task
branch
from
5781046 to
bc2203b
Compare
Member
Author
|
I should use this test as a base to make sure that that we can exercise these code paths. We should duplicate this with a space-ified project path to ensure coverage. |
baronfel
changed the title
Member
Author
|
Having a hard time verifying that the test I added actually results in a test asset with a space in it. VS doesn't like me at the moment to debug. |
Contributor
|
Approved for 6.0.4xx as well |
Member
Author
|
Branding PR has merged bumping to 6.0.305, so merging this. |
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Quotes file paths passed to the BrotliCompress tool as command line arguments so that the generated response file has the expected format for paths that include spaces.
Closes #26026
Customer Impact
Customers with Blazor WebAssembly projects that have a space in the path to the project could not publish their projects at all. They had to change the folder structure to no longer include a space to make publishing work again.
Regression
Yes, this regressed in 6.0.301 due to a change in System.CommandLine response file parsing. We fixed this for the CLI overall in an earlier fix, but missed this tool due to lack of test coverage for this particular scenario, as well as these standalone tools not using the same CLI processing logic as the 'core'
dotnettool (for good reason, since tools like the brotli compress tool are internal-only and should be free to change). This is present in 6.0.400 and onwards as well.Risk
Low - the change only impacts file paths that are not already quoted and uses an existing mechanism for quoting. Automated tests have also been added to cover building/publishing in paths that contain a space.