From 0f854974eab9b27cf804c2d7442d86da51722f97 Mon Sep 17 00:00:00 2001 From: Chet Husk Date: Thu, 8 Sep 2022 15:49:45 -0500 Subject: [PATCH] Quote file paths for the BrotliCompress tool (#27213) * quote the file paths for the brotli command to adhere to System.CommandLine token-expansion rules * Add test to cover spaces in project path for blazor tools --- src/BlazorWasmSdk/Tasks/BrotliCompress.cs | 4 ++-- .../WasmBuildIntegrationTest.cs | 8 +++++--- 2 files changed, 7 insertions(+), 5 deletions(-) diff --git a/src/BlazorWasmSdk/Tasks/BrotliCompress.cs b/src/BlazorWasmSdk/Tasks/BrotliCompress.cs index 8f5b69f808cd..f2e305585b48 100644 --- a/src/BlazorWasmSdk/Tasks/BrotliCompress.cs +++ b/src/BlazorWasmSdk/Tasks/BrotliCompress.cs @@ -111,10 +111,10 @@ protected override string GenerateResponseFileCommands() } builder.AppendLine("-s"); - builder.AppendLine(inputFullPath); + builder.AppendLine(Quote(inputFullPath)); builder.AppendLine("-o"); - builder.AppendLine(outputFullPath); + builder.AppendLine(Quote(outputFullPath)); } return builder.ToString(); diff --git a/src/Tests/Microsoft.NET.Sdk.BlazorWebAssembly.Tests/WasmBuildIntegrationTest.cs b/src/Tests/Microsoft.NET.Sdk.BlazorWebAssembly.Tests/WasmBuildIntegrationTest.cs index 8ddb31a889a2..4dfbfd94a3dd 100644 --- a/src/Tests/Microsoft.NET.Sdk.BlazorWebAssembly.Tests/WasmBuildIntegrationTest.cs +++ b/src/Tests/Microsoft.NET.Sdk.BlazorWebAssembly.Tests/WasmBuildIntegrationTest.cs @@ -43,12 +43,14 @@ public void BuildMinimal_Works() new FileInfo(Path.Combine(buildOutputDirectory, "wwwroot", "_framework", "blazorwasm-minimal.dll")).Should().Exist(); } - [Fact] - public void Build_Works() + [Theory] + [InlineData("blazor")] + [InlineData("blazor spaces")] + public void Build_Works(string identifier) { // Arrange var testAppName = "BlazorWasmWithLibrary"; - var testInstance = CreateAspNetSdkTestAsset(testAppName); + var testInstance = CreateAspNetSdkTestAsset(testAppName, identifier: identifier); var buildCommand = new BuildCommand(testInstance, "blazorwasm"); buildCommand.Execute()