Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.Sign up
Don't set MSBuildAllProjects for MSBuild 16.0+ #2853
microsoft/msbuild#1299 discusses a change whereby MSBuild prepends the newest project file path to
This reduction applies equally to consumers, such as for the case discussed in dotnet/project-system#3744.
For backwards compatibility the property is still set for MSBuild versions prior to 16.0.
See also microsoft/msbuild#3605.
If it's safe to remove them outright then that's a better approach, and given your commit we can close this PR.
It's marked as
referenced this pull request
Jan 22, 2019
How is that enforced? ie What will prevent this from "just working" if I run MSBuild.exe (v15) against a project that only has 3.0 installed.
@davkean the 3.0 CLI has a file that establishes 16.0 as the minimum MSBuild version it requires. This file is then honored by the SDK Resolver that msbuild uses to find the .NET Core SDK props/targets. Users would have to edit this file inside the SDK installation to get around that. At that point, I would say all bets are OFF.