Skip to content

[release/7.0.2xx] Update dependencies from dotnet/templating #29803

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 11 commits into from
Jan 11, 2023
Merged

[release/7.0.2xx] Update dependencies from dotnet/templating #29803

merged 11 commits into from
Jan 11, 2023

Conversation

@dotnet-maestro
Copy link
Contributor

@dotnet-maestro dotnet-maestro bot commented Jan 6, 2023 •
edited
Loading

This pull request updates the following dependencies

From https://github.com/dotnet/templating

  • Subscription: 96eb62f0-1e90-4013-9883-08daa5872937
  • Build: 20230110.3
  • Date Produced: January 10, 2023 9:25:02 PM UTC
  • Commit: f8bc164534a6967dd2ab3114a6fcf27df8b206f1
  • Branch: refs/heads/release/7.0.2xx

@dotnet-maestro
Update dependencies from https://github.com/dotnet/templating build 2…
19e603f 
…0230106.10

Microsoft.TemplateEngine.Abstractions , Microsoft.TemplateEngine.Mocks
 From Version 7.0.200-alpha.1.23053.1 -> To Version 7.0.200-alpha.1.23056.10
@ghost ghost added the Area-CodeFlow label Jan 6, 2023
@YuliiaKovalova YuliiaKovalova requested a review from a team as a code owner January 6, 2023 15:00
dotnet-maestro bot and others added 3 commits January 6, 2023 16:27
@dotnet-maestro
Update dependencies from https://github.com/dotnet/templating build 2…
c82efbd 
…0230106.15

Microsoft.TemplateEngine.Abstractions , Microsoft.TemplateEngine.Mocks
 From Version 7.0.200-alpha.1.23053.1 -> To Version 7.0.200-alpha.1.23056.15
@YuliiaKovalova
Merge remote-tracking branch 'origin/release/7.0.2xx' into darc-relea…
b537576 
…se/7.0.2xx-6dbf5406-4041-4b06-904d-89075feb4759
@dotnet-maestro
Update dependencies from https://github.com/dotnet/templating build 2…
147308d 
…0230109.4

Microsoft.TemplateEngine.Abstractions , Microsoft.TemplateEngine.Mocks
 From Version 7.0.200-alpha.1.23053.1 -> To Version 7.0.200-alpha.1.23059.4
@nagilson
Copy link
Member

nagilson commented Jan 9, 2023 •
edited
Loading

First is

##[error]src\Tests\xunit-runner\XUnitRunner.targets(78,5): error MSB4062: (NETCORE_ENGINEERING_TELEMETRY=Build) The "SDKCustomCreateXUnitWorkItemsWithTestExclusion" task could not be loaded from the assembly D:\a\1\s\artifacts\\bin\HelixTasks\Debug\netcoreapp3.1\HelixTasks.dll. Could not load file or assembly 'D:\a\1\s\artifacts\bin\HelixTasks\Debug\netcoreapp3.1\HelixTasks.dll'. The system cannot find the path specified. Confirm that the <UsingTask> declaration is correct, that the assembly and all its dependencies are available, and that the task contains a public class that implements Microsoft.Build.Framework.ITask.

Another thing is why are these packages being downgraded? Is this something we would expect? Need to know before we can merge.

I see review has been requested from @dotnet/templating-engine-maintainers so won't take further action here yet.

@nagilson nagilson added the Area-dotnet new the item is related to dotnet new command label Jan 9, 2023
@YuliiaKovalova
Copy link
Member

YuliiaKovalova commented Jan 10, 2023

hi @nagilson ,

I am working on this issue.
It appeared to be a sneaky one.

JanKrivanek and others added 5 commits January 10, 2023 14:49
@JanKrivanek @YuliiaKovalova
Adjust conditional params tests
3880775
@YuliiaKovalova
merge adjusted conditional tests
93eb906
@YuliiaKovalova
Merge remote-tracking branch 'origin/release/7.0.2xx' into darc-relea…
da7dae5 
…se/7.0.2xx-6dbf5406-4041-4b06-904d-89075feb4759
@YuliiaKovalova
fix failed tests
2467807
@dotnet-maestro
Update dependencies from https://github.com/dotnet/templating build 2…
d6ba019 
…0230110.3

Microsoft.TemplateEngine.Abstractions , Microsoft.TemplateEngine.Mocks
 From Version 7.0.200-alpha.1.23053.1 -> To Version 7.0.200-alpha.1.23060.3
@YuliiaKovalova
Copy link
Member

YuliiaKovalova commented Jan 11, 2023

Hi @nagilson ,

templating changes are ready. We can deliver this pr.
Thank you!

@nagilson
Copy link
Member

nagilson commented Jan 11, 2023

Awesome, thank you! 😉

@nagilson nagilson enabled auto-merge January 11, 2023 17:44
@nagilson nagilson merged commit c2bd684 into release/7.0.2xx Jan 11, 2023
@nagilson nagilson deleted the darc-release/7.0.2xx-6dbf5406-4041-4b06-904d-89075feb4759 branch January 11, 2023 17:44
@JanKrivanek JanKrivanek mentioned this pull request Jan 12, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@nagilson nagilson nagilson approved these changes

Assignees

No one assigned

Labels

Area-CodeFlow Area-dotnet new the item is related to dotnet new command

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@nagilson @YuliiaKovalova @JanKrivanek