Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove duplicates items from resolved publish assets. #3021

Merged
merged 1 commit into from Mar 14, 2019

Conversation

Projects
None yet
3 participants
@peterhuene
Copy link
Member

peterhuene commented Mar 14, 2019

When CopyLocalLockFileAssemblies was true, ReferenceCopyLocalPaths
contained the set of RuntimePackAsset items.

When resolving assets to copy local for publish, the RuntimePackAsset items
were added twice: once explicitly and again via ReferenceCopyLocalPaths.

This commit fixes this by only adding to the resolved copy local assets for
publish when CopyLocalLockFileAssemblies is false.

Fixes #3007.

@peterhuene peterhuene added this to the 3.0.1xx milestone Mar 14, 2019

@peterhuene peterhuene requested a review from dotnet/dotnet-cli Mar 14, 2019

Remove duplicates items from resolved publish assets.
When `CopyLocalLockFileAssemblies` was true, `ReferenceCopyLocalPaths`
contained the set of `RuntimePackAsset` items.

When resolving assets to copy local for publish, the `RuntimePackAsset` items
were added twice: once explicitly and again via `ReferenceCopyLocalPaths`.

This commit fixes this by only adding to the resolved copy local assets for
publish when `CopyLocalLockFileAssemblies` is false.

Fixes #3007.

@peterhuene peterhuene force-pushed the peterhuene:fix-duplicate-publish branch from f434485 to 4c81292 Mar 14, 2019

@peterhuene peterhuene merged commit 98d209f into dotnet:master Mar 14, 2019

2 checks passed

license/cla All CLA requirements met.
Details
public-CI (3) #20190313.4 succeeded
Details

@peterhuene peterhuene deleted the peterhuene:fix-duplicate-publish branch Mar 14, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.