Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use PackageDownload #3111

Merged
merged 5 commits into from Apr 16, 2019

Conversation

Projects
None yet
5 participants
@dsplaisted
Copy link
Member

dsplaisted commented Apr 11, 2019

Fix dotnet/cli#10440 (we will need dotnet/project-system#4567 to be able to support this in VS).

@dsplaisted dsplaisted closed this Apr 11, 2019

@dsplaisted dsplaisted reopened this Apr 11, 2019

@dsplaisted dsplaisted closed this Apr 11, 2019

@dsplaisted dsplaisted reopened this Apr 11, 2019

@dsplaisted dsplaisted closed this Apr 11, 2019

@dsplaisted dsplaisted reopened this Apr 11, 2019

@dsplaisted dsplaisted force-pushed the dsplaisted:use-packagedownload branch from 1f7d769 to f5de7e0 Apr 11, 2019

@dsplaisted dsplaisted marked this pull request as ready for review Apr 11, 2019

@rainersigwald

This comment has been minimized.

Copy link
Contributor

rainersigwald commented Apr 11, 2019

/AzurePipelines run

@azure-pipelines

This comment has been minimized.

Copy link

azure-pipelines bot commented Apr 11, 2019

For the Azure DevOps organization dotnet, no matching pipelines using the Azure Pipelines app were found for this pull request.

@rainersigwald

This comment has been minimized.

Copy link
Contributor

rainersigwald commented Apr 11, 2019

/AzurePipelines run

@chcosta

This comment has been minimized.

Copy link
Member

chcosta commented Apr 11, 2019

/azp run

@azure-pipelines

This comment has been minimized.

Copy link

azure-pipelines bot commented Apr 11, 2019

Azure Pipelines successfully started running 1 pipeline(s).

1 similar comment
@azure-pipelines

This comment has been minimized.

Copy link

azure-pipelines bot commented Apr 11, 2019

Azure Pipelines successfully started running 1 pipeline(s).

@rainersigwald

This comment has been minimized.

Copy link
Contributor

rainersigwald commented Apr 11, 2019

@chcosta Jinx!

dsplaisted added some commits Apr 11, 2019

Download AppHost packs for RIDs specified in RuntimeIdentifiers
This lets you restore once and then build for separate RIDs without re-restoring

@dsplaisted dsplaisted requested review from peterhuene and dotnet/dotnet-cli Apr 12, 2019

@dsplaisted

This comment has been minimized.

Copy link
Member Author

dsplaisted commented Apr 13, 2019

/azp run

@azure-pipelines

This comment has been minimized.

Copy link

azure-pipelines bot commented Apr 13, 2019

Azure Pipelines successfully started running 1 pipeline(s).

@@ -19,6 +19,8 @@ public class ResolveAppHosts : TaskBase

public string AppHostRuntimeIdentifier { get; set; }

public string [] OtherRuntimeIdentifiers { get; set; }

This comment has been minimized.

Copy link
@nguerrera

nguerrera Apr 15, 2019

Member

nit, extra space between string and []

</PropertyGroup>

<ItemGroup Condition="'$(UsePackageDownload)' == 'true'">
<PackageDownload Include="@(_PackageToDownload)">

This comment has been minimized.

Copy link
@wli3

wli3 Apr 15, 2019

Collaborator

just help me understanding this nuget feature, we use PackageDownload to download, but i didn't find the code to dig (i think it is in)nuget cache.

This comment has been minimized.

Copy link
@dsplaisted

dsplaisted Apr 15, 2019

Author Member

It's the GetPackageDirectory task. It doesn't change with this PR, with PackageDownload, the packages are downloaded to the same place that the would have been with PackageReference.

@dsplaisted dsplaisted merged commit a0fe8df into dotnet:master Apr 16, 2019

1 check passed

license/cla All CLA requirements met.
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.